From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
Glauber Costa <glommer@redhat.com>
Cc: kvm <kvm@vger.kernel.org>
Subject: Re: error while loading state for instance 0x0 of device 'kvmclock'
Date: Mon, 02 Nov 2009 11:28:38 +0100 [thread overview]
Message-ID: <4AEEB456.1000006@siemens.com> (raw)
In-Reply-To: <4AEE99F5.5000509@web.de>
Jan Kiszka wrote:
> Hi,
>
> current qemu-kvm.git gives me the message "qemu: warning: error while
> loading state for instance 0x0 of device 'kvmclock'" when I run a simple
> "savevm" followed by a "loadvm 1". What's broken here?
OK, this is due to "KVM: add flags to kvm_clock_data" (958b0c5497): the
flags field is not cleared on KVM_SET_CLOCK. Will post a fix.
But the above kernel commit is also broken: KVM_GET_CLOCK checks
uninitialized user_ns.flags (probably instead of the user's value). This
raises the question if the caller of KVM_GET_CLOCK is also supposed to
pass kvm_clock_data with flags cleared down to the kernel. Could someone
clarify this so I could fix it accordingly?
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2009-11-02 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 8:36 error while loading state for instance 0x0 of device 'kvmclock' Jan Kiszka
2009-11-02 10:28 ` Jan Kiszka [this message]
2009-11-02 12:29 ` Marcelo Tosatti
2009-11-02 13:36 ` Avi Kivity
2009-11-02 15:37 ` Jan Kiszka
2009-11-03 10:54 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEEB456.1000006@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.