From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org,
Netfilter Core Team <coreteam@netfilter.org>
Subject: Re: [PATCH 2/3] xtables: deactivate intrapositional support
Date: Mon, 02 Nov 2009 17:17:58 +0100 [thread overview]
Message-ID: <4AEF0636.6010604@trash.net> (raw)
In-Reply-To: <1256891969-18437-3-git-send-email-jengelh@medozas.de>
Jan Engelhardt wrote:
> In going to fix NF bug #611, "argv" would be needed in
> xtables_check_inverse to set "optarg" to the right spot in case of an
> intrapositional negation. Adding argv to the parameter list would
> cause an API change, which I would like to avoid because it is
> planned to be thrown out anyway.
>
> So deactive intrapositional support now already, but leave the error
> message (which has already been there for two releases). Slightly
> adjust it, because some users have been wondering whether iptables
> or they are at "fault".
I'm worried that this is too early, two releases is not particulary
long and I'd expect a lot of people haven't noticed the warning yet,
especially on headless systems. Looking at bug #611, we've never
claimed "-ptcp" would be supported, so this hardly justifies the
risk IMO.
At least this needs more discussion, I'd like to hear a few more
opinions on this.
next prev parent reply other threads:[~2009-11-02 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 8:39 iptables optarg fix Jan Engelhardt
2009-10-30 8:39 ` [PATCH 1/3] style: reduce indent in xtables_check_inverse Jan Engelhardt
2009-10-30 8:39 ` [PATCH 2/3] xtables: deactivate intrapositional support Jan Engelhardt
2009-11-02 16:17 ` Patrick McHardy [this message]
2009-11-02 18:59 ` Jan Engelhardt
2009-11-03 18:39 ` Patrick McHardy
2009-11-02 20:49 ` Jozsef Kadlecsik
2009-11-03 18:39 ` Patrick McHardy
2009-10-30 8:39 ` [PATCH 3/3] iptables/extensions: make bundled options work again Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEF0636.6010604@trash.net \
--to=kaber@trash.net \
--cc=coreteam@netfilter.org \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.