All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
To: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] Add a choosepid() syscall as a simpler alternative to clone_with_pids()
Date: Mon, 02 Nov 2009 16:02:13 -0500	[thread overview]
Message-ID: <4AEF48D5.7070201@librato.com> (raw)
In-Reply-To: <87ws281weu.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>



Dan Smith wrote:
> OL> 2. What do you expect to gain by splitting the work into two
> OL> separate system calls ?
> 
> Simplicity and avoidance of the arch-specific issues, which seems to
> be what hung us up on $NEW_CLONE_NAME_O'_THE_DAY.

Adding a syscall, a field on current, and a set of rules how those
are managed, is not simpler IMHO.

Some objections in the past argued that this may cause unexpected
behavior to the user or tracing/debugging tools. I'm not sure to
what extend this still is, but those will come again.

Finally, I disagree with the prognosis: the arch-specific issue that
hung the today's-clone was introducing *a* new clone such that its
args are passed incorrectly from a _technical_ point of view.

The thing is, that we need a new clone anyway (if not only for the
flags), and that new clone will have to get its args correctly.

On the other hand, Suka fixed his arch-dependent part and we're left
with agreeing on a new plausible name ...

That said, if you manage to get that to mainline, I'll be fine with
it (and then someone later will need to extend clone somehow). I only
think that chances are slim.

Oren.

  parent reply	other threads:[~2009-11-02 21:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 20:38 [PATCH] Add a choosepid() syscall as a simpler alternative to clone_with_pids() Dan Smith
     [not found] ` <1257194293-12099-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-02 20:48   ` Oren Laadan
     [not found]     ` <4AEF45BB.4080609-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-11-02 20:52       ` Dan Smith
     [not found]         ` <87ws281weu.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-11-02 21:02           ` Oren Laadan [this message]
2009-11-02 22:10       ` Serge E. Hallyn
2009-11-03 15:44   ` Oren Laadan
     [not found]     ` <4AF04FE9.6090301-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-11-03 21:43       ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AEF48D5.7070201@librato.com \
    --to=orenl-rdfvbdnroixbdgjk7y7tuq@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.