From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: c/s 20384 Date: Mon, 02 Nov 2009 13:08:36 -0800 Message-ID: <4AEF4A54.2030806@goop.org> References: <4AEEA3BB020000780001D146@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4AEEA3BB020000780001D146@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com, Keir Fraser List-Id: xen-devel@lists.xenproject.org On 11/02/09 00:17, Jan Beulich wrote: > Keir, > > I'm having the impression that this c/s unintentionally modifies behavior in > certain ways: > > - map_vcpu_info() no longer sets evtchn_upcall_mask for a newly mapped > info struct > - VCPUOP_initialise no longer fails when a vCPU didn't have a proper info > struct installed > - the changes to xen/common/event_channel.c make it so that > dummy_vcpu_info can be written to, and hence subsequently initialized > vcpu_info structs would have unpredictable initial state > What's the real changeset id you're referring to? The small-integer numbers are only locally valid (and globally by coincidence), and 20384 here doesn't seem at all relevant to your points. I you're referring to f74f0c1ae8ab, which is 21773 in my tree... J