From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mbroz@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
	by mail.saout.de (Postfix) with ESMTP
	for <dm-crypt@saout.de>; Tue,  3 Nov 2009 11:31:32 +0100 (CET)
Message-ID: <4AF00682.6000006@redhat.com>
Date: Tue, 03 Nov 2009 11:31:30 +0100
From: Milan Broz <mbroz@redhat.com>
MIME-Version: 1.0
References: <1256220968-2387-1-git-send-email-ludwig.nussel@suse.de>	<4AEFF20A.4000700@redhat.com>
	<20091103110849.389e850d@tanana.suse.de>
In-Reply-To: <20091103110849.389e850d@tanana.suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [dm-crypt] [PATCH] print warning when adding a key that
 contains non-ASCII characters
List-Id: <dm-crypt.saout.de>
List-Unsubscribe: <http://www.saout.de/mailman/options/dm-crypt>,
	<mailto:dm-crypt-request@saout.de?subject=unsubscribe>
List-Archive: <http://www.saout.de/pipermail/dm-crypt>
List-Post: <mailto:dm-crypt@saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Subscribe: <http://www.saout.de/mailman/listinfo/dm-crypt>,
	<mailto:dm-crypt-request@saout.de?subject=subscribe>
To: Ludwig Nussel <ludwig.nussel@suse.de>
Cc: dm-crypt@saout.de

On 11/03/2009 11:08 AM, Ludwig Nussel wrote:
>> I don't think this in good idea. Information that user entered non-ASCII
>> character is useful for attacker, why display it to terminal?
>> (That problem exist in all password entry dialogs - why cryptsetup should
>> be special here?)
> 
> It's only displayed if you add a new password. I doubt you usually
> do that if someone's looking at your screen. He could just look at
> your keyboard while you are typing as well then, right? :-)

No. Output can be logged (installer debug output for example).
If the warning is not there, I know that user have only ascii chars
in password.

Milan
--
mbroz@redhat.com