From: Nishanth Menon <nm@ti.com>
To: Vikram Pandita <vikram.pandita@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/8] omap: DEBUG_LL: allow no omap uart configuration
Date: Tue, 3 Nov 2009 16:09:34 -0600 [thread overview]
Message-ID: <4AF0AA1E.8020502@ti.com> (raw)
In-Reply-To: <1257283215-6448-3-git-send-email-vikram.pandita@ti.com>
Vikram Pandita had written, on 11/03/2009 03:20 PM, the following:
[...]
> diff --git a/arch/arm/plat-omap/include/plat/uncompress.h b/arch/arm/plat-omap/include/plat/uncompress.h
> index e22f575..49b38f0 100644
> --- a/arch/arm/plat-omap/include/plat/uncompress.h
> +++ b/arch/arm/plat-omap/include/plat/uncompress.h
> @@ -44,8 +44,10 @@ static void putc(int c)
> uart = (volatile u8 *)(OMAP_UART3_BASE);
> #elif defined(CONFIG_OMAP_LL_DEBUG_UART2)
> uart = (volatile u8 *)(OMAP_UART2_BASE);
> -#else
> +#elif defined(CONFIG_OMAP_LL_DEBUG_UART1)
> uart = (volatile u8 *)(OMAP_UART1_BASE);
> +#elif defined(CONFIG_OMAP_LL_DEBUG_NONE)
> + return;
what is the default? an #else missing? maybe, we might want to use:
#else
return;
also I am not clear about
#ifdef CONFIG_MACH_OMAP_PALMTE
return
#endif
Vs this -> should'nt PALMTE also use this instead?
unrelated.. purpose of #ifdef CONFIG_ARCH_OMAP in
arch/arm/plat-omap/include/plat/uncompress.h
is'nt it already OMAP?
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2009-11-03 22:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 21:20 [PATCH 0/8] RFC: introduce 3630 boards Vikram Pandita
2009-11-03 21:20 ` [PATCH 1/8] omap: 3630: update is_chip variable Vikram Pandita
2009-11-03 21:20 ` [PATCH 2/8] omap: DEBUG_LL: allow no omap uart configuration Vikram Pandita
2009-11-03 21:20 ` [PATCH 3/8] omap: zoom2: split baord file for reuse Vikram Pandita
2009-11-03 21:20 ` [PATCH 4/8] omap: zoom2: update defconfig Vikram Pandita
2009-11-03 21:20 ` [PATCH 5/8] omap: zoom3: introduce zoom3 board support Vikram Pandita
2009-11-03 21:20 ` [PATCH 6/8] omap: zoom3: defconfig creation Vikram Pandita
2009-11-03 21:20 ` [PATCH 7/8] omap: 3630sdp: introduce 3630 sdp board support Vikram Pandita
2009-11-03 21:20 ` [PATCH 8/8] omap: 3630sdp: defconfig creation Vikram Pandita
2009-11-03 22:31 ` [PATCH 7/8] omap: 3630sdp: introduce 3630 sdp board support Nishanth Menon
2009-11-03 22:28 ` [PATCH 5/8] omap: zoom3: introduce zoom3 " Nishanth Menon
2009-11-04 7:09 ` [PATCH 4/8] omap: zoom2: update defconfig G, Manjunath Kondaiah
2009-11-03 22:17 ` [PATCH 3/8] omap: zoom2: split baord file for reuse Nishanth Menon
2009-11-03 22:09 ` Nishanth Menon [this message]
2009-11-03 21:23 ` [PATCH 0/8] RFC: introduce 3630 boards Pandita, Vikram
2009-11-03 21:26 ` Pandita, Vikram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF0AA1E.8020502@ti.com \
--to=nm@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.