From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <uwe.menges@web.de>
Received: from h604816.serverkompetenz.net (h604816.serverkompetenz.net
	[81.169.142.96]) by mail.saout.de (Postfix) with ESMTP
	for <dm-crypt@saout.de>; Tue,  3 Nov 2009 23:40:02 +0100 (CET)
Message-ID: <4AF0B141.8050609@web.de>
Date: Tue, 03 Nov 2009 23:40:01 +0100
From: Uwe Menges <uwe.menges@web.de>
MIME-Version: 1.0
References: <1256220968-2387-1-git-send-email-ludwig.nussel@suse.de>
	<20091103084749.21a94a09@tanana.suse.de>
In-Reply-To: <20091103084749.21a94a09@tanana.suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [dm-crypt] [PATCH] print warning when adding a key that
 contains non-ASCII characters
List-Id: <dm-crypt.saout.de>
List-Unsubscribe: <http://www.saout.de/mailman/options/dm-crypt>,
	<mailto:dm-crypt-request@saout.de?subject=unsubscribe>
List-Archive: <http://www.saout.de/pipermail/dm-crypt>
List-Post: <mailto:dm-crypt@saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Subscribe: <http://www.saout.de/mailman/listinfo/dm-crypt>,
	<mailto:dm-crypt-request@saout.de?subject=subscribe>
To: Ludwig Nussel <ludwig.nussel@suse.de>
Cc: dm-crypt@saout.de

Ludwig Nussel wrote:
> Any opinions?

Your patch uses the isascii() call, but the problem "different keymap at
different password entering times" is IMHO not really related to the
question "is the character ascii or not". It's all too easy to run into
exact the same situation you want to prevent, with just plain ascii
chars in the password.

Yours, Uwe