All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai-core <xenomai@xenomai.org>,
	Paolo Bernini <paolo.bernini@domain.hid>
Subject: [Xenomai-core] [pull request] rtdm: Add padding to rtser_config
Date: Tue, 03 Nov 2009 23:54:44 +0100	[thread overview]
Message-ID: <4AF0B4B4.3020609@domain.hid> (raw)

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]

The following changes since commit 6b1a185b460765c933b17932d77be6967d2e42dc:
  Philippe Gerum (1):
        nucleus: fix locking in shared heap deletion

are available in the git repository at:

  git://git.xenomai.org/xenomai-jki.git for-upstream

Jan Kiszka (1):
      rtdm: Add padding to rtser_config

 include/rtdm/rtserial.h |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

---

rtdm: Add padding to rtser_config

The current layout of rtser_config is unfortunate as it may result in
different layout depending on the compiler alignment setting. Namely,
rx_timeout may be aligned on 8-byte boundaries in user land while it may
not be aligned in the kernel, or vice versa.

Avoid this ambiguity by adding a reserved padding field. Bump profile
revision number due to ABI breakage.

Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
---
 include/rtdm/rtserial.h |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/rtdm/rtserial.h b/include/rtdm/rtserial.h
index 30bb564..48712b2 100644
--- a/include/rtdm/rtserial.h
+++ b/include/rtdm/rtserial.h
@@ -29,7 +29,7 @@
  * Feel free to comment on this profile via the Xenomai mailing list
  * (Xenomai-core@domain.hid) or directly to the author (jan.kiszka@domain.hid).
  *
- * @b Profile @b Revision: 2
+ * @b Profile @b Revision: 3
  * @n
  * @n
  * @par Device Characteristics
@@ -79,7 +79,7 @@
 
 #include <rtdm/rtdm.h>
 
-#define RTSER_PROFILE_VER		2
+#define RTSER_PROFILE_VER		3
 
 /*!
  * @anchor RTSER_DEF_BAUD   @name RTSER_DEF_BAUD
@@ -263,6 +263,8 @@ typedef struct rtser_config {
 	/** reception FIFO interrupt threshold, see @ref RTSER_FIFO_xxx */
 	int		fifo_depth;
 
+	int		reserved;
+
 	/** reception timeout, see @ref RTSER_TIMEOUT_xxx for special
 	 *  values */
 	nanosecs_rel_t	rx_timeout;
-- 
1.6.0.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

             reply	other threads:[~2009-11-03 22:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03 22:54 Jan Kiszka [this message]
2009-11-04 11:41 ` [Xenomai-core] [pull request] rtdm: Add padding to rtser_config Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF0B4B4.3020609@domain.hid \
    --to=jan.kiszka@domain.hid \
    --cc=paolo.bernini@domain.hid \
    --cc=rpm@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.