From: Tim Blechmann <tim@klingt.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa: echoaudio - pci id cleanup
Date: Wed, 04 Nov 2009 10:07:52 +0100 [thread overview]
Message-ID: <4AF14468.7010006@klingt.org> (raw)
In-Reply-To: <s5h8wemzog1.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 803 bytes --]
On 11/04/2009 09:25 AM, Takashi Iwai wrote:
> At Sat, 17 Oct 2009 11:48:23 +0200,
> Tim Blechmann wrote:
>>
>> using the PCI_VENDOR_ID_MOTOROLA definition instead of the value 0x1057
>> makes code a bit cleaner.
>>
>> Signed-off-by: Tim Blechmann <tim@klingt.org>
>
> Well, I'm not always fond of this. The only merit is that you can avoid
> a typo. But, if you look for a device from the source code from lspci,
> this kind of change makes it hard.
it helps, if this device is referred to by PCI_VENDOR_ID_MOTOROLA
instead of 0x1057, as it is done somewhere in the cardbus code ...
but since it is a rather cosmetic fix, feel free to drop the patch ...
tim
--
tim@klingt.org
http://tim.klingt.org
You don't have to call it music if the term shocks you.
John Cage
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2009-11-04 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-17 9:48 [PATCH] alsa: echoaudio - pci id cleanup Tim Blechmann
2009-11-04 8:25 ` Takashi Iwai
2009-11-04 9:07 ` Tim Blechmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF14468.7010006@klingt.org \
--to=tim@klingt.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.