From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5cLU-0001pu-NX for qemu-devel@nongnu.org; Wed, 04 Nov 2009 04:40:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5cLP-0001p8-Ov for qemu-devel@nongnu.org; Wed, 04 Nov 2009 04:40:04 -0500 Received: from [199.232.76.173] (port=44290 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5cLP-0001p5-JF for qemu-devel@nongnu.org; Wed, 04 Nov 2009 04:39:59 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:40207) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5cLP-0007vS-1M for qemu-devel@nongnu.org; Wed, 04 Nov 2009 04:39:59 -0500 Message-ID: <4AF14BDB.3050306@web.de> Date: Wed, 04 Nov 2009 10:39:39 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1257258596-4556-1-git-send-email-amit.shah@redhat.com> <1257258596-4556-2-git-send-email-amit.shah@redhat.com> <1257258596-4556-3-git-send-email-amit.shah@redhat.com> <4AF063A9.7000908@siemens.com> <20091103175552.GA25029@amit-x200.redhat.com> <20091103180934.GA25423@amit-x200.redhat.com> <4AF07C37.9040904@web.de> <20091104052113.GA27028@amit-x200.redhat.com> In-Reply-To: <20091104052113.GA27028@amit-x200.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig77860571F91A67CD8FFDC2FD" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig77860571F91A67CD8FFDC2FD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Amit Shah wrote: > On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: >> Amit Shah wrote: >>> On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: >>>> On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: >>>>> Amit Shah wrote: >>>>>> The initial_reset sent to chardevs doesn't do much other than sett= ing >>>>>> a bool to true. Char devices are interested in the open event and >>>>>> that gets sent whenever the device is opened. >>>>> Have you checked with the monitor in all use cases (dedicated & mux= ed >>>>> console, stdio & SDL console, etc.)? It was introduced once to fix = a >>>> I've checked with -monitor stdio, monitor in SDL and also chardevs u= sing >>>> unix sockets. >>>> >>>> I've not tried mux yet; I'll try that and report back. BTW if it end= s up >>>> not working with this patch, it'd be broken in the current master as= >>>> well. >>> I tried with: >>> >>> -chardev stdio,mux=3Don,id=3Dmux -monitor chardev:mux -serial chardev= :mux >>> >>> The monitor prompt shows up as does the serial output. >>> >>> (btw I've also tried closing and opening char devs and that works fin= e >>> too) >> That sounds good. Then something must have changed since 2970a6c943, d= o >> you see what? >=20 > I think that depended on the resets being sent. I've now removed the > need for resets altogether. No, this is in fact the reason why we no longer need it: 9a1e948129 (Introduce contexts for asynchronous callbacks) As the initial reset of the char device that is marked pending on open is now no longer consumed by the IDE initialization, we can actually drop the later regeneration via qemu_chr_initial_reset. I just hope this stays like it is... Jan --------------enig77860571F91A67CD8FFDC2FD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkrxS+0ACgkQitSsb3rl5xReewCfU4y5HaGoVyiDkISaVoptDfau Q0gAn1cNkQAhKHEdjEmYL9F09H/olDEA =6p+1 -----END PGP SIGNATURE----- --------------enig77860571F91A67CD8FFDC2FD--