From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v3 4/4] KVM: x86: Add VCPU substate for event states
Date: Wed, 04 Nov 2009 13:23:02 +0200
Message-ID: <4AF16416.5030803@redhat.com>
References: <20091102162028.19049.34651.stgit@mchn012c.ww002.siemens.net> <20091102162029.19049.22980.stgit@mchn012c.ww002.siemens.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:61451 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755383AbZKDLXB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 Nov 2009 06:23:01 -0500
In-Reply-To: <20091102162029.19049.22980.stgit@mchn012c.ww002.siemens.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/02/2009 06:20 PM, Jan Kiszka wrote:
> This new substate exports all yet user-invisible states related to
> exceptions, interrupts, and NMIs. Together with appropriate user space
> changes, this fixes sporadic problems of vmsave/restore, live migration
> and system reset.
>    

> +		events.exception.injected = vcpu->arch.exception.pending;
> +		events.exception.nr = vcpu->arch.exception.nr;
> +		events.exception.error_code = vcpu->arch.exception.error_code;
>    

we're missing has_error_code here.

-- 
error compiling committee.c: too many arguments to function