From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v3 4/4] KVM: x86: Add VCPU substate for event states Date: Wed, 04 Nov 2009 12:34:28 +0100 Message-ID: <4AF166C4.9080802@siemens.com> References: <20091102162028.19049.34651.stgit@mchn012c.ww002.siemens.net> <20091102162029.19049.22980.stgit@mchn012c.ww002.siemens.net> <4AF16416.5030803@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from goliath.siemens.de ([192.35.17.28]:20670 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755422AbZKDLeh (ORCPT ); Wed, 4 Nov 2009 06:34:37 -0500 In-Reply-To: <4AF16416.5030803@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > On 11/02/2009 06:20 PM, Jan Kiszka wrote: >> This new substate exports all yet user-invisible states related to >> exceptions, interrupts, and NMIs. Together with appropriate user space >> changes, this fixes sporadic problems of vmsave/restore, live migration >> and system reset. >> > >> + events.exception.injected = vcpu->arch.exception.pending; >> + events.exception.nr = vcpu->arch.exception.nr; >> + events.exception.error_code = vcpu->arch.exception.error_code; >> > > we're missing has_error_code here. > Isn't it statically defined by the arch? exception_has_error_code() regenerates it (just like user land does). Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux