From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v3 4/4] KVM: x86: Add VCPU substate for event states Date: Wed, 04 Nov 2009 14:51:33 +0200 Message-ID: <4AF178D5.2040008@redhat.com> References: <20091102162028.19049.34651.stgit@mchn012c.ww002.siemens.net> <20091102162029.19049.22980.stgit@mchn012c.ww002.siemens.net> <4AF16416.5030803@redhat.com> <4AF166C4.9080802@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1025 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755629AbZKDMvd (ORCPT ); Wed, 4 Nov 2009 07:51:33 -0500 In-Reply-To: <4AF166C4.9080802@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/04/2009 01:34 PM, Jan Kiszka wrote: > >> we're missing has_error_code here. >> >> > Isn't it statically defined by the arch? exception_has_error_code() > regenerates it (just like user land does). > In real mode exceptions lose their error code, so we have to look at cr0, and now we depend on the order of loading of state... -- error compiling committee.c: too many arguments to function