From: Gilad Ben-Yossef <gilad@codefidence.com>
To: David Miller <davem@davemloft.net>
Cc: Valdis.Kletnieks@vt.edu, netdev@vger.kernel.org,
ori@comsleep.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/1] Use defaults when no route options are available
Date: Wed, 04 Nov 2009 16:27:13 +0200 [thread overview]
Message-ID: <4AF18F41.9040500@codefidence.com> (raw)
In-Reply-To: <20091104.052816.74593826.davem@davemloft.net>
David Miller wrote:
> From: Gilad Ben-Yossef <gilad@codefidence.com>
> Date: Tue, 3 Nov 2009 21:21:25 +0200
>
>
>> Trying to parse the option of a SYN packet that we have
>> no route entry for should just use global wide defaults
>> for route entry options.
>>
>> Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com>
>>
>
> The tester has indicated that this doesn't solve things
> for them. I suspect there is another dependency on 'dst'
> not being NULL in another path somewhere.
>
> So until this is fully resolved I'm holding off on applying
> this patch.
>
>
Yes, indeed.
I managed to replicate it here. Looking into it right now.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker & CTO
Codefidence Ltd.
Web: http://codefidence.com
Cell: +972-52-8260388
Skype: gilad_codefidence
Tel: +972-8-9316883 ext. 201
Fax: +972-8-9316884
Email: gilad@codefidence.com
Check out our Open Source technology and training blog - http://tuxology.net
"The biggest risk you can take it is to take no risk."
-- Mark Zuckerberg and probably others
prev parent reply other threads:[~2009-11-04 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 17:50 2.6.32-rc5-mmotm1101 - kernel BUG at net/ipv4/tcp_input.c:3707! Valdis.Kletnieks
2009-11-03 18:02 ` Eric Dumazet
2009-11-03 19:20 ` Gilad Ben-Yossef
2009-11-03 21:34 ` Ilpo JÀrvinen
2009-11-04 2:01 ` Valdis.Kletnieks
2009-11-04 2:34 ` David Miller
2009-11-04 6:38 ` Gilad Ben-Yossef
2009-11-04 16:40 ` [PATCH testing] Do not call IPv4 specific func in tcp_check_req Gilad Ben-Yossef
2009-11-05 7:22 ` David Miller
2009-11-04 16:43 ` 2.6.32-rc5-mmotm1101 - kernel BUG at net/ipv4/tcp_input.c:3707! Gilad Ben-Yossef
2009-11-05 2:33 ` Valdis.Kletnieks
2009-11-05 7:25 ` David Miller
2009-11-05 7:22 ` David Miller
2009-11-04 6:27 ` Gilad Ben-Yossef
2009-11-03 19:21 ` [PATCH 1/1] Use defaults when no route options are available Gilad Ben-Yossef
2009-11-04 13:28 ` David Miller
2009-11-04 14:27 ` Gilad Ben-Yossef [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF18F41.9040500@codefidence.com \
--to=gilad@codefidence.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ori@comsleep.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.