From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v3 4/4] KVM: x86: Add VCPU substate for event states
Date: Wed, 04 Nov 2009 15:44:26 +0100
Message-ID: <4AF1934A.2020506@siemens.com>
References: <20091102162028.19049.34651.stgit@mchn012c.ww002.siemens.net> <20091102162029.19049.22980.stgit@mchn012c.ww002.siemens.net> <4AF16416.5030803@redhat.com> <4AF166C4.9080802@siemens.com> <4AF178D5.2040008@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from thoth.sbs.de ([192.35.17.2]:24420 "EHLO thoth.sbs.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756616AbZKDOoh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 Nov 2009 09:44:37 -0500
In-Reply-To: <4AF178D5.2040008@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> On 11/04/2009 01:34 PM, Jan Kiszka wrote:
>>> we're missing has_error_code here.
>>>
>>>      
>> Isn't it statically defined by the arch? exception_has_error_code()
>> regenerates it (just like user land does).
>>    
> 
> In real mode exceptions lose their error code, so we have to look at 
> cr0, and now we depend on the order of loading of state...

I see. Will add it in v4.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux