From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>,
Marius Storm-Olsen <mstormo@gmail.com>
Subject: Re: [PATCH 3/4] Makefile: keep MSVC and Cygwin configuration separate
Date: Wed, 04 Nov 2009 19:29:09 +0000 [thread overview]
Message-ID: <4AF1D605.1020900@ramsay1.demon.co.uk> (raw)
In-Reply-To: <4AEFDB6B.8010209@viscovery.net>
Johannes Sixt wrote:
>
> I like the direction of this change, but I think that you must use ':='
Yeah, I've always been a bit sloppy with recursive assignment versus simple
assignment when the value does not contain a variable reference ;-)
So yes, you are right...
> assignment, and I would put this right after the uname_* assignments at
> the beginning of the Makefile:
>
> uname_V := $(shell sh -c 'uname -v 2>/dev/null || echo not')
> +ifdef MSVC
> + uname_S := Windows
> + uname_O := Windows # avoid cygwin configuration
> +endif
OK with me. (but you are avoiding the MinGW configuration as well...)
ATB,
Ramsay Jones
prev parent reply other threads:[~2009-11-04 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 19:13 [PATCH 3/4] Makefile: keep MSVC and Cygwin configuration separate Ramsay Jones
2009-11-03 7:27 ` Johannes Sixt
2009-11-04 19:29 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF1D605.1020900@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=mstormo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.