All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Thompson <nick.thompson@gefanuc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] da8xx
Date: Thu, 05 Nov 2009 09:32:36 +0000	[thread overview]
Message-ID: <4AF29BB4.2060401@gefanuc.com> (raw)
In-Reply-To: <4AF23C68.3090603@windriver.com>

Tom wrote:
> The v4 is looking good.
> No regressions on MAKEALL arm
> 
> Are there any outstanding issues besides needing lowercase variable names and 
> the pin multiplex dependency ?
> 
> Tom

Sekhar Nori over at TI was kind enough to review this for me prior to submission.
The only outstanding question was whether clk_get() should be used by the rest of
DaVinci as well as DA8xx.

The answer is probably yes, but this implementation relies on the C structure
register overlays, which DaVinci devices do not yet use. Changing DaVinci is
outside the remit of adding DA8xx support I believe.

One question relating to lower case variable names. You said:

> > +#define PINMUX	&DAVINCI_SYSCFG_REGS->pinmux
> > +
>
> Lowercase variables
> Apply globally.

These are not true variables, but #defines. Is it considered okay to use lowercase
in this kind of situation? I would be happier with lowercase, I admit.

I would have preferred to use static "const" variables, but of coursse C doesn't
allow those to be used in static assignments as they are not really constant. Bah.

Thanks,
Nick.

      reply	other threads:[~2009-11-05  9:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  2:46 [U-Boot] da8xx Tom
2009-11-05  9:32 ` Nick Thompson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF29BB4.2060401@gefanuc.com \
    --to=nick.thompson@gefanuc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.