From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Xiaowei" Subject: RE: [PATCH] ioemu: fix drive name parsing Date: Thu, 05 Nov 2009 18:08:05 +0800 Message-ID: <4AF2A405.9090404@intel.com> References: <4AF27686.4020100@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4AF27686.4020100@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org > Yang, Xiaowei writes ("[Xen-devel] [PATCH] ioemu: fix drive name parsing"): > > In xenstore_parse_domain_config(), 'any_hdN' is overridden by local version > > accidentally. > > Thanks for spotting this. You're right that it's a bug. I've applied > your patch (although really I think this whole area is pretty grotty > and could do with substantial rework). > > Two comments though about the formatting of your patch: > > * It didn't apply cleanly because it had different whitespace to > that in the actual code. Your mailer must have done something to There must be something wrong when I did the paste. > it I think. Best practice seems to be (if you can't make your > mailer reliably not mangle the body of the message) to provide each > patch _both_ as an attachment (for application) _and_ by including > it in the body (for readable review). Thanks for the advice. I'll attach the patch also next time. > > * You forgot the Signed-off-By line, by which you would certify that I added the signed-off-by line at the bottom!:) Thanks, xiaowei > the code copyright and so forth status was appropriate (according > to the Developer's Certificate of Origin). I applied your patch > anyway because it's a one-line change (which most authorities think > makes it too small for copyright to apply) but you should make sure > to appropriately certify your code in future. >