From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linux-ppc list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/3] powerpc/83xx/suspend: Clear deep_sleeping after devices resume
Date: Thu, 05 Nov 2009 10:57:42 -0600 [thread overview]
Message-ID: <4AF30406.3080101@freescale.com> (raw)
In-Reply-To: <043A102D-9F70-4287-B34E-17FF9AE90EE1@kernel.crashing.org>
Kumar Gala wrote:
>
> On Sep 23, 2009, at 2:01 PM, Anton Vorontsov wrote:
>
>> Currently 83xx PMC driver clears deep_sleeping variable very early,
>> before devices are resumed. This makes fsl_deep_sleep() unusable in
>> drivers' resume() callback.
>>
>> Sure, drivers can store fsl_deep_sleep() value on suspend and use
>> the stored value on resume. But a better solution is to postpone
>> clearing the deep_sleeping variable, i.e. move it into finish()
>> callback.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> ---
>> arch/powerpc/platforms/83xx/suspend.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Scott, any comments or an ack?
ACK
-Scott
next prev parent reply other threads:[~2009-11-05 16:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 19:00 [PATCH 0/3] powerpc/83xx: Sleep and deep sleep support for MPC8315E-RDB Anton Vorontsov
2009-09-23 19:01 ` [PATCH 1/3] powerpc/83xx/suspend: Clear deep_sleeping after devices resume Anton Vorontsov
2009-11-05 14:57 ` Kumar Gala
2009-11-05 16:57 ` Scott Wood [this message]
2009-11-05 18:36 ` Kumar Gala
2009-11-05 19:48 ` Scott Wood
2009-11-05 19:59 ` Kumar Gala
2009-11-05 20:03 ` Scott Wood
2009-11-05 20:09 ` Anton Vorontsov
2009-11-05 20:25 ` Scott Wood
2009-11-05 20:30 ` Anton Vorontsov
2009-09-23 19:01 ` [PATCH 2/3] powerpc/83xx/suspend: Save and restore SICRL, SICRH and SCCR Anton Vorontsov
2009-09-23 19:01 ` [PATCH 3/3] powerpc/83xx: Add power management support for MPC8315E-RDB boards Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2009-12-10 17:59 [PATCH v2 0/3] powerpc/83xx: Sleep and deep sleep support for MPC8315E-RDB Anton Vorontsov
2009-12-10 18:00 ` [PATCH 1/3] powerpc/83xx/suspend: Clear deep_sleeping after devices resume Anton Vorontsov
2009-12-11 1:56 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF30406.3080101@freescale.com \
--to=scottwood@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.