From: Shi Weihua <shiwh@cn.fujitsu.com>
To: ltp-list <ltp-list@lists.sourceforge.net>
Subject: [LTP] [PATCH] Fix build failure in cgroup_fj testcase
Date: Fri, 06 Nov 2009 09:35:11 +0800 [thread overview]
Message-ID: <4AF37D4F.1020909@cn.fujitsu.com> (raw)
The following build failure occured on my x86 box.
-------------------------------------------------------
# uname -a
Linux F8-i386 2.6.32-rc5-tipshiwh+ #3 SMP Wed Oct 21 15:14:54 EDT 2009 i686 i686 i386 GNU/Linux
# cat /etc/issue
Fedora release 8 (Werewolf)
Kernel \r on an \m
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/shiwh/ltp-full-20091031/testcases/kernel/include -I/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -Wall -O2 -Wextra -I../../../../include -I../../../../include -L/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -L../../../../lib cgroup_fj_proc.c -lltp -lcontrollers -o cgroup_fj_proc
/usr/bin/ld: cannot find -lcontrollers
collect2: ld returned 1 exit status
make[4]: *** [cgroup_fj_proc] Error 1
make[4]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases'
make: *** [testcases-all] Error 2
-------------------------------------------------------
But the case "cgroup_fj" does not need "-lcontrollers" when building.
So in my patch, i deleted "-lcontrollers" in testcases/kernel/controllers/Makefile.inc
and added it to testcases/kernel/controllers/memctl/Makefile because the case "memctl"
need it.
All other cases in testcases/kernel/controllers/ build well too when my patch merged.
Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
---
diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/Makefile.inc ltp-full-20091031/testcases/kernel/controllers/Makefile.inc
--- ltp-full-20091031.orig/testcases/kernel/controllers/Makefile.inc 2009-11-02 04:07:13.000000000 -0500
+++ ltp-full-20091031/testcases/kernel/controllers/Makefile.inc 2009-11-05 08:54:06.000000000 -0500
@@ -39,8 +39,6 @@ CPPFLAGS += -I$(abs_srcdir)/../$(LIBDIR
LDFLAGS += -L$(abs_builddir)/../$(LIBDIR)
-LDLIBS += -lcontrollers
-
INSTALL_TARGETS ?= *.sh
# vim: syntax=make
diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/memctl/Makefile ltp-full-20091031/testcases/kernel/controllers/memctl/Makefile
--- ltp-full-20091031.orig/testcases/kernel/controllers/memctl/Makefile 2009-11-02 04:07:14.000000000 -0500
+++ ltp-full-20091031/testcases/kernel/controllers/memctl/Makefile 2009-11-06 04:13:49.000000000 -0500
@@ -27,4 +27,6 @@ include $(abs_srcdir)/../Makefile.inc
INSTALL_TARGETS := *.sh
+LDLIBS += -lcontrollers
+
include $(top_srcdir)/include/mk/generic_leaf_target.mk
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next reply other threads:[~2009-11-06 2:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 1:35 Shi Weihua [this message]
2009-11-09 17:39 ` [LTP] [PATCH] Fix build failure in cgroup_fj testcase Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF37D4F.1020909@cn.fujitsu.com \
--to=shiwh@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.