From: Patrick McHardy <kaber@trash.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev <netdev@vger.kernel.org>, Jouni Malinen <j@w1.fi>,
Thomas Graf <tgraf@suug.ch>
Subject: Re: [RFC] netlink: add socket destruction notification
Date: Fri, 06 Nov 2009 16:21:29 +0100 [thread overview]
Message-ID: <4AF43EF9.3020707@trash.net> (raw)
In-Reply-To: <1254473048.3959.76.camel@johannes.local>
Johannes Berg wrote:
> When we want to keep track of resources associated with applications, we
> need to know when an app is going away. Add a notification function to
> netlink that tells us that, and also hook it up to generic netlink so
> generic netlink can notify the families. Due to the way generic netlink
> works though, we need to notify all families and they have to sort out
> whatever resources some commands associated with the socket themselves.
>
> @@ -166,6 +167,9 @@ static void netlink_sock_destruct(struct
> return;
> }
>
> + if (nlk->destruct)
> + nlk->destruct(sk);
> +
> WARN_ON(atomic_read(&sk->sk_rmem_alloc));
> WARN_ON(atomic_read(&sk->sk_wmem_alloc));
> WARN_ON(nlk_sk(sk)->groups);
This seems pretty similar to the NETLINK_URELEASE notifier invoked
in netlink_release(). Wouldn't that one work as well?
next prev parent reply other threads:[~2009-11-06 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 8:44 [RFC] netlink: add socket destruction notification Johannes Berg
2009-11-06 5:08 ` David Miller
2009-11-06 8:55 ` Johannes Berg
2009-11-06 15:21 ` Patrick McHardy [this message]
2009-11-06 15:26 ` Johannes Berg
2009-11-06 15:37 ` Patrick McHardy
2009-11-09 10:22 ` Johannes Berg
2009-11-09 12:59 ` Patrick McHardy
2009-11-09 13:03 ` Johannes Berg
2009-11-09 13:19 ` Patrick McHardy
2009-11-09 16:51 ` Johannes Berg
2009-11-09 16:57 ` Patrick McHardy
2009-11-09 17:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF43EF9.3020707@trash.net \
--to=kaber@trash.net \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.