From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 29/31] xen_destroy_irq + xen_allocate_pirq
 in PV non-priv mode should not make certain Xen-HYPERCALLs.
Date: Fri, 06 Nov 2009 13:38:15 -0800
Message-ID: <4AF49747.6060203@goop.org>
References: <1257456819-782-1-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-15-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-16-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-17-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-18-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-19-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-20-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-21-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-22-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-23-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-24-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-25-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-26-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-27-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-28-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-29-git-send-email-konrad.wilk@oracle.com>
	<1257456819-782-30-git-send-email-konrad.wilk@oracl e.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1257456819-782-30-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 11/05/09 13:33, Konrad Rzeszutek Wilk wrote:
> The privileged domain should make these calls for the guest.
> The non-privileged domain should make these calls via the pcifront
> interface (patches that augment these two functions to do so
> will follow).
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  drivers/xen/events.c |   30 ++++++++++++++++--------------
>  1 files changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 40bcbde..fd55b5b 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -606,14 +606,15 @@ int xen_destroy_irq(int irq)
>  	if (!desc)
>  		goto out;
>  
> -	unmap_irq.pirq = info->u.pirq.nr;
> -	unmap_irq.domid = info->u.pirq.domid;
>   

This doesn't apply to my tree because these lines read:
    unmap_irq.pirq = info->u.pirq.nr;
    unmap_irq.domid = DOMID_SELF;

I'm not sure where the creep happened.  Oh, perhaps because I applied
the pcifront and back series in different branches?  Ah, yes, that's
it.  I'll see if I can sort it out.

    J