From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH PV_OPS PCIFRONT] Date: Fri, 06 Nov 2009 13:40:14 -0800 Message-ID: <4AF497BE.1030806@goop.org> References: <1257456819-782-1-git-send-email-konrad.wilk@oracle.com> <20091105220414.GA3820@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091105220414.GA3820@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 11/05/09 14:04, Konrad Rzeszutek Wilk wrote: >> That is it for right now. The driver works with INTx and MSI cards. I've tested >> with USB and network (Broadcom) succesfully. There is still some more work to do: >> - MSI disable is not yet in, >> - no MSI-X enable/disable functionality. >> > and: > - If 4GB or more are allocated to the domain, you get this: > > PCI: Warning: Cannot find a gap in the 32bit address range > PCI: Unassigned devices with 32bit resource registers may break! > > and the device shows up as disabled and is not usuable. > Presumably less than 4G can trigger this. My rough thought about this was to always reserve a chunk of memory under 4G to make space for this kind of thing, and push the displaced memory higher. > - No support yet for 'reassign_device' which page aligns the BARs > on PCI devices. > > - Haven't tested FLR or PCI AER. > - Saw this once: > > WARNING: at drivers/pci/msi.c:602 pci_enable_msi_block+0xcd/0x339() > .. snip .. > Call Trace: > [] warn_slowpath_common+0xc9/0x10c > [] warn_slowpath_null+0x30/0x4d > [] pci_enable_msi_block+0xcd/0x339 > [] ? pciback_do_op+0x0/0x1b4 > [] pciback_enable_msi+0x3e/0xb0 > [] pciback_do_op+0xcd/0x1b4 > ..snip.. > What does that warning mean? > But besides that it works :-) > Good! I'll throw it into the mix and see how it flies. J