All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-core] [PATCH] Check frequency in xnarch_init_timeconv()
Date: Sun, 08 Nov 2009 10:17:28 +0100	[thread overview]
Message-ID: <4AF68CA8.6010105@domain.hid> (raw)
In-Reply-To: <1257111269.2065.596.camel@domain.hid>

Hi,

Philippe Gerum schrieb:
> 
> I agree with the conclusion, not with the fix.

Thanks for reviewing the patch and sorry for the late answer.

> - the kernel side should rather test RTHAL_CPU_FREQ for consistency in
> the generic hal init code, and bail out with an error if 0 is detected,
> since there is no way for the nucleus to operate properly with such
> setting anyway.
> 
> It turns out that no change have to be done in xnarch_init_timeconv()
> which should remain a void routine, but its argument - RTHAL_CPU_FREQ -
> should rather be tested as early as possible for consistency, directly
> from kernel space.

I'll post a new patch right now.


Regards,
Bernhard



  reply	other threads:[~2009-11-08  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-01 19:58 [Xenomai-core] [PATCH] Check frequency in xnarch_init_timeconv() Bernhard Walle
2009-11-01 21:34 ` Philippe Gerum
2009-11-08  9:17   ` Bernhard Walle [this message]
2009-11-08  9:18     ` [Xenomai-core] [PATCH] Check CPU frequency Bernhard Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF68CA8.6010105@domain.hid \
    --to=bernhard@domain.hid \
    --cc=rpm@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.