From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Alan Cox <alan@linux.intel.com>
Cc: mel@csn.ul.fi, linux-kernel@vger.kernel.org,
Nick Piggin <npiggin@suse.de>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] slqb: A not quite so trivial warning
Date: Sun, 08 Nov 2009 13:39:13 +0200 [thread overview]
Message-ID: <4AF6ADE1.60201@cs.helsinki.fi> (raw)
In-Reply-To: <20091106112942.14595.29799.stgit@localhost.localdomain>
Hi Alan,
Alan Cox wrote:
> mm/slqb.c:2773: warning: initialization from incompatible pointer type
>
> Variable scope...
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
I don't see this warning in my tree. Is this coming from linux-next? Did
someone change DEFINE_PER_CPU not to prefix the variable name with
"per_cpu__"?
Pekka
> ---
>
> mm/slqb.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>
> diff --git a/mm/slqb.c b/mm/slqb.c
> index e745d9a..fddcf85 100644
> --- a/mm/slqb.c
> +++ b/mm/slqb.c
> @@ -2770,16 +2770,16 @@ static DEFINE_PER_CPU(struct delayed_work, cache_trim_work);
>
> static void __cpuinit start_cpu_timer(int cpu)
> {
> - struct delayed_work *cache_trim_work = &per_cpu(cache_trim_work, cpu);
> + struct delayed_work *lcache_trim_work = &per_cpu(cache_trim_work, cpu);
>
> /*
> * When this gets called from do_initcalls via cpucache_init(),
> * init_workqueues() has already run, so keventd will be setup
> * at that time.
> */
> - if (keventd_up() && cache_trim_work->work.func == NULL) {
> - INIT_DELAYED_WORK(cache_trim_work, cache_trim_worker);
> - schedule_delayed_work_on(cpu, cache_trim_work,
> + if (keventd_up() && lcache_trim_work->work.func == NULL) {
> + INIT_DELAYED_WORK(lcache_trim_work, cache_trim_worker);
> + schedule_delayed_work_on(cpu, lcache_trim_work,
> __round_jiffies_relative(HZ, cpu));
> }
> }
>
next prev parent reply other threads:[~2009-11-08 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 11:29 [PATCH] slqb: A not quite so trivial warning Alan Cox
2009-11-08 11:39 ` Pekka Enberg [this message]
2009-11-08 11:58 ` Alan Cox
2009-11-08 12:04 ` Tejun Heo
2009-11-08 12:29 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF6ADE1.60201@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.fi \
--cc=npiggin@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.