From: Hauke Mehrtens <hauke@hauke-m.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: IvDoorn@gmail.com, gwingerde@gmail.com,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [PATCH] rt2x00: fix build of rt2800lib
Date: Sun, 08 Nov 2009 14:27:38 +0100 [thread overview]
Message-ID: <4AF6C74A.4020208@hauke-m.de> (raw)
In-Reply-To: <200911081325.23424.bzolnier@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 5650 bytes --]
Hi,
I am building recent wireless-testing. Without my patch I get the
following error while compiling it with CONFIG_RT2800USB=y with
CONFIG_RT2800USB=m it compiles fine without any modifications. Looks
like there is an other problem and my patch does not fix the real problem.
Hauke
CC drivers/net/wireless/rt2x00/rt2800lib.o
In file included from drivers/net/wireless/rt2x00/rt2800lib.c:35:
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_vendor_request_sw':
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: 'USB_DIR_OUT'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: (Each undeclared
identifier is reported only once
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: for each function it
appears in.)
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:205: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_eeprom_read':
drivers/net/wireless/rt2x00/rt2x00usb.h:223: error: 'USB_DIR_IN'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:223: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:223: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_read':
drivers/net/wireless/rt2x00/rt2x00usb.h:243: error: 'USB_DIR_IN'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:243: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:243: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_read_lock':
drivers/net/wireless/rt2x00/rt2x00usb.h:263: error: 'USB_DIR_IN'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:263: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:263: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_multiread':
drivers/net/wireless/rt2x00/rt2x00usb.h:283: error: 'USB_DIR_IN'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:283: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:283: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_write':
drivers/net/wireless/rt2x00/rt2x00usb.h:303: error: 'USB_DIR_OUT'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:303: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:303: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_write_lock':
drivers/net/wireless/rt2x00/rt2x00usb.h:322: error: 'USB_DIR_OUT'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:322: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:322: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: In function
'rt2x00usb_register_multiwrite':
drivers/net/wireless/rt2x00/rt2x00usb.h:342: error: 'USB_DIR_OUT'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:342: error: 'USB_TYPE_VENDOR'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h:342: error: 'USB_RECIP_DEVICE'
undeclared (first use in this function)
drivers/net/wireless/rt2x00/rt2x00usb.h: At top level:
drivers/net/wireless/rt2x00/rt2x00usb.h:439: warning: 'struct
usb_interface' declared inside parameter list
drivers/net/wireless/rt2x00/rt2x00usb.h:439: warning: its scope is only
this definition or declaration, which is probably not what you want
drivers/net/wireless/rt2x00/rt2x00usb.h:440: warning: 'struct
usb_interface' declared inside parameter list
drivers/net/wireless/rt2x00/rt2x00usb.h:442: warning: 'struct
usb_interface' declared inside parameter list
drivers/net/wireless/rt2x00/rt2x00usb.h:443: warning: 'struct
usb_interface' declared inside parameter list
make[4]: *** [drivers/net/wireless/rt2x00/rt2800lib.o] Error 1
make[3]: *** [drivers/net/wireless/rt2x00] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Fehler 2
Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> Could you please tell us more about build problems you have
> encountered and which kernel tree this fix is for?
>
> Thanks.
>
> On Sunday 08 November 2009 13:07:01 Hauke Mehrtens wrote:
>> rt2x00usb.h uses lots of definitions from linux/usb.h.
>> ---
>> drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index 5c7d74a..b601a1a 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -29,6 +29,7 @@
>>
>> #include <linux/kernel.h>
>> #include <linux/module.h>
>> +#include <linux/usb.h>
>>
>> #include "rt2x00.h"
>> #ifdef CONFIG_RT2800USB
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 898 bytes --]
next prev parent reply other threads:[~2009-11-08 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 12:07 [PATCH] rt2x00: fix build of rt2800lib Hauke Mehrtens
2009-11-08 12:25 ` Bartlomiej Zolnierkiewicz
2009-11-08 13:27 ` Hauke Mehrtens [this message]
2009-11-08 17:31 ` Bartlomiej Zolnierkiewicz
2009-11-09 22:24 ` Gertjan van Wingerde
2009-11-08 12:37 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF6C74A.4020208@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=IvDoorn@gmail.com \
--cc=bzolnier@gmail.com \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.