Re: [lm-sensors] [PATCH] hwmon: (adt7475) Fix temperature fault

[Hans de Goede <hdegoede@redhat.com>]

Hmm,

I've a adt7475 on my home development machine in the Netherlands
(I'm currently in Brno).

I can (and would like to) verify this fix when I'm back home (friday).
The adt7475 on my machine is used to control an additional fan, and has
no external temperature sensors connected (AFAIK).

I've tested the original adt7475 driver on this machine, but I may
have simply out "temp1 ignore" (and temp3) in my sensors.conf missing
this.

Regards,

Hans


On 11/09/2009 11:37 AM, Jean Delvare wrote:
> The logic of temperature fault flags is wrong, it shows faults when
> there are none and vice versa. Fix it.
>
> I can't believe this has been broken since the driver was added, 8
> months ago, basically breaking temp1 and temp3, and nobody ever
> complained.
>
> Signed-off-by: Jean Delvare<khali@linux-fr.org>
> Cc: Hans de Goede<hdegoede@redhat.com>
> Cc: Jordan Crouse<jordan@cosmicpenguin.net>
> ---
>   drivers/hwmon/adt7475.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- linux-2.6.32-rc6.orig/drivers/hwmon/adt7475.c	2009-11-08 19:21:34.000000000 +0100
> +++ linux-2.6.32-rc6/drivers/hwmon/adt7475.c	2009-11-08 19:22:06.000000000 +0100
> @@ -350,8 +350,7 @@ static ssize_t show_temp(struct device *
>
>   	case FAULT:
>   		/* Note - only for remote1 and remote2 */
> -		out = data->alarms&  (sattr->index ? 0x8000 : 0x4000);
> -		out = out ? 0 : 1;
> +		out = !!(data->alarms&  (sattr->index ? 0x8000 : 0x4000));
>   		break;
>
>   	default:
>
>

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors