From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N7VKU-0007mI-Fi for mharc-grub-devel@gnu.org; Mon, 09 Nov 2009 09:34:50 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7VKS-0007jN-1a for grub-devel@gnu.org; Mon, 09 Nov 2009 09:34:48 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7VKN-0007fh-FE for grub-devel@gnu.org; Mon, 09 Nov 2009 09:34:47 -0500 Received: from [199.232.76.173] (port=44931 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7VKN-0007fe-9k for grub-devel@gnu.org; Mon, 09 Nov 2009 09:34:43 -0500 Received: from ey-out-1920.google.com ([74.125.78.149]:65416) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7VKM-0006YO-RT for grub-devel@gnu.org; Mon, 09 Nov 2009 09:34:43 -0500 Received: by ey-out-1920.google.com with SMTP id 3so706685eyh.34 for ; Mon, 09 Nov 2009 06:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=zm1OSQF1bBHlBKltC37o1K7GLv7jIT8FOMfJOse4IA0=; b=MN39z9WUtEstYHQTzCCCij7tHhd9wId/SEOmPFf/8FlFojPGNR2Da4oGwubB4UVqeC YnNKUoTu0zohgButgP4xijJoq38cmvXAcBOYZtmUIF86vj598Of0ZC2VQayLfWOPjjG3 9S8q3mi+bAgtQIA5r7UQSmMB8vwDJecMHFzAM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=lAfgTo2DcoXHjDMqZnQiOeKnT8QB1FBIFVLvkCJKSHeD1jzxbn57S3slSataVMR5nr Yij+1SsNPhUNYUlAyQd4dvFZXpALf+tRu7YFl9peGRnyuUsfxUS/ntrNUsXfTsF3mtFT 319dKlrAG7Q6IVqE0xn8iKqhJODEM6qYy5WN8= Received: by 10.213.100.138 with SMTP id y10mr9050825ebn.96.1257777281824; Mon, 09 Nov 2009 06:34:41 -0800 (PST) Received: from debian.bg45.phnet (gprs01.swisscom-mobile.ch [193.247.250.1]) by mx.google.com with ESMTPS id 23sm6646130eya.20.2009.11.09.06.34.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 09 Nov 2009 06:34:40 -0800 (PST) Message-ID: <4AF82868.6090803@gmail.com> Date: Mon, 09 Nov 2009 15:34:16 +0100 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GNU GRUB References: <20091109010422.GA23417@thorin> <4AF81E2C.2090700@gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig661AEB61440184DEE08EA8C8" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Imminent bugfix release (1.97.1) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2009 14:34:48 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig661AEB61440184DEE08EA8C8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Bean wrote: > On Mon, Nov 9, 2009 at 9:50 PM, Vladimir 'phcoder' Serbinenko > wrote: > =20 >> Bean wrote: >> =20 >>> On Mon, Nov 9, 2009 at 9:04 AM, Robert Millan wrote= : >>> >>> =20 >>>> A security problem [1] was found in our password-checking routines, >>>> which affects GRUB 1.97. I'll be releasing 1.97.1 tomorrow. >>>> >>>> Additionally, I cherry-picked fixes for a few problems that should >>>> have made it to the release, like GNU/Hurd support (see NEWS file >>>> for details). The release branch is available in: >>>> >>>> sftp://bzr.savannah.gnu.org/srv/bzr/grub/branches/release_1_97/ >>>> >>>> If you have time, please test this tree, specially password support,= >>>> to help find possible problems. >>>> >>>> =20 >>> Hi, >>> >>> Actually, the function of grub_auth_strcmp puzzles me, why would it >>> need to wait 100 ms to return the result ? >>> =20 >> 10 ms actually. The goal is to take same amount of time indpendently o= f >> input values. But probably the delay should be around whole thing and >> it's how I'll do but for this urgent release this will do it >> =20 > > Hi, > > int > grub_auth_strcmp (const char *s1, const char *s2) > { > int ret; > grub_uint64_t end; > > end =3D grub_get_time_ms () + 100; > ret =3D grub_strcmp (s1, s2); > > /* This prevents an attacker from deriving information about the > password from the time it took to execute this function. */ > while (grub_get_time_ms () < end); > > return ret; > } > > Isn't this 100 ms ? Anyway, the longest supported string is 1024 long, > I doubt there is any perceivable difference between them. > > =20 If attacker is on fast serial connection he could possibly measure the difference --=20 Regards Vladimir 'phcoder' Serbinenko --------------enig661AEB61440184DEE08EA8C8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkr4KHsACgkQNak7dOguQgkK+QD+Ierwja/DunTnRVl6YoA+WqRl +hiFpTCJx2MUxzObtQMA/27MvjpiJw/iL/9KfEop3AfEQMPEBWDgjXnMl/2gtQaL =OeEY -----END PGP SIGNATURE----- --------------enig661AEB61440184DEE08EA8C8--