From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N7dv2-0002SD-SM for mharc-grub-devel@gnu.org; Mon, 09 Nov 2009 18:45:08 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7dv1-0002Ra-KY for grub-devel@gnu.org; Mon, 09 Nov 2009 18:45:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7dv0-0002RF-Us for grub-devel@gnu.org; Mon, 09 Nov 2009 18:45:07 -0500 Received: from [199.232.76.173] (port=45874 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7dv0-0002R9-MS for grub-devel@gnu.org; Mon, 09 Nov 2009 18:45:06 -0500 Received: from 75-63-108-1.uvs.hstntx.sbcglobal.net ([75.63.108.1]:39590 helo=ubuntu-mail.griffin.net) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N7dv0-0001Gw-6J for grub-devel@gnu.org; Mon, 09 Nov 2009 18:45:06 -0500 Received: from [192.168.0.157] by ubuntu-mail.griffin.net with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.67) (envelope-from ) id 1N7ei8-0001tX-Kx for grub-devel@gnu.org; Mon, 09 Nov 2009 18:36:03 -0600 Message-ID: <4AF8A12B.1030908@griffin.net> Date: Mon, 09 Nov 2009 17:09:31 -0600 From: Darron Black User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: The development of GNU GRUB References: <4AF85568.7080105@duboucher.eu> <20091109181010.GA7372@thorin> <4AF85C54.3080302@gmail.com> <20091109182518.GA14767@thorin> <4AF86387.7090307@gmail.com> <4AF885EE.7000709@duboucher.eu> <4AF88AEF.8010102@gmail.com> <4AF88D14.2030108@duboucher.eu> <20091109220654.GA22226@thorin> <4AF89BC1.5040608@duboucher.eu> In-Reply-To: <4AF89BC1.5040608@duboucher.eu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Spam_score_int: -43 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: Imminent bugfix release (1.97.1) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2009 23:45:07 -0000 Duboucher Thomas wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Robert Millan a écrit : > >> On Mon, Nov 09, 2009 at 10:43:48PM +0100, Duboucher Thomas wrote: >> >>> Well, the only way to solve that problem would be IMHO to add a limit >>> to the size of s2, and use this maximum size as an end condition for the >>> 'for' statement. Any better idea? :) >>> >> We have a maximum line read size anyway. If we do this, we might as >> well make that limit global so that the macro can be shared with >> this routine. >> >> > > Sounds good to me. :) > Any ideas for renaming s1 and s2? > > Thomas. > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (MingW32) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iEYEARECAAYFAkr4m8EACgkQBV7eXqefhqj9SgCgjHomnoIkzzu5WuTCZQVcB/8t > cwcAn1EkevCL3PXGlIuhLzFPlER9fXD3 > =okR/ > -----END PGP SIGNATURE----- > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > Hello, I'd be concerned about (s1 != s2). Depending on how efficiently this compiles, could not branch prediction make this faster for match vs. not match, etc?. I'd be worried about all the ways (and future ways) compilers might help us and introduce time differences. I'd feel most comfortable with the time delay, but why not stick to complete artithmetic? int i; int acc = 0; for(i=0;i. Just = / !=. However, my context being so new is quite limited. Darron