From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH] x86 boot: simplify reloc.c
Date: Tue, 10 Nov 2009 16:21:20 +0800
Message-ID: <4AF92280.2060307@cn.fujitsu.com>
References: <C71EC891.19B0B%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C71EC891.19B0B%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>, Xiao Guangrong <ericxiao.gr@gmail.com>
List-Id: xen-devel@lists.xenproject.org



Keir Fraser wrote:
> On 10/11/2009 03:34, "Xiao Guangrong" <xiaoguangrong@cn.fujitsu.com> wrote:
> 
>> This patch simplify reloc.c with:
>> 1): no need separate make
>>     reloc.c -> reloc.o -> reloc.lnk -> reloc.bin -> reloc.S,
>>     and static embed reloc.S into head.S
>> 2): reuse memcpy() in string lib
>> 3): remove assemble code in the head of reloc.c
>>
>> [ It is just a cleanup patch and not change the code's logic, and it work well
>> on x86.
>>   Not have x86_64 machine in my hand, thanks very much if someone can test it
>> on x86_64 ]
> 
> The patch misses the point of reloc.c, which is that it is supposed to run
> in 32-bit mode. All the stuff you stripped out is exactly what's needed to
> make it work with 64-bit Xen.
> 

Ah, sorry for this noise, I'll do some work on x86-64 about this patch.

Thanks,
Xiao