All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <James.Smart@Emulex.Com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"andrew.vasquez@qlogic.com" <andrew.vasquez@qlogic.com>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: Re: [PATCH] scsi_lib_dma.c :  fix bug with dma maps on nested scsi objects - (2nd try)
Date: Tue, 10 Nov 2009 09:38:45 -0500	[thread overview]
Message-ID: <4AF97AF5.2090700@emulex.com> (raw)
In-Reply-To: <1257449592.10355.26.camel@mulgrave.site>

James,

This updated patch works fine for lpfc and our vports...

Acked-By: James Smart  <james.smart@emulex.com>

-- james s


James Bottomley wrote:
> 
> 141 lines plus a static list to solve a simple problem is getting a bit
> icky to say the least.
> 
> What about being more simplistic and simply making the host cache a
> pointer to the physical bus device?  I probably objected to this a long
> time ago because using the parent pointers is more elegant, but I think
> this patch demonstrates conclusively it's not worth this amount of code
> for the sake of alleged elegance.
> 
> James
> 
> ---
>  drivers/scsi/hosts.c            |   13 ++++++++++---
>  drivers/scsi/lpfc/lpfc_init.c   |    2 +-
>  drivers/scsi/qla2xxx/qla_attr.c |    3 ++-
>  drivers/scsi/scsi_lib_dma.c     |    4 ++--
>  include/scsi/scsi_host.h        |   16 +++++++++++++++-
>  5 files changed, 30 insertions(+), 8 deletions(-)

      reply	other threads:[~2009-11-10 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04  0:45 [PATCH] scsi_lib_dma.c : fix bug with dma maps on nested scsi objects - (2nd try) James Smart
2009-11-04  0:45 ` James Smart
2009-11-05 19:33 ` James Bottomley
2009-11-10 14:38   ` James Smart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF97AF5.2090700@emulex.com \
    --to=james.smart@emulex.com \
    --cc=James.Bottomley@suse.de \
    --cc=andrew.vasquez@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.