From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: Re: [PATCH] Add hypercall to expose physical CPU
	in xen hypervisor
Date: Tue, 10 Nov 2009 10:00:25 -0800
Message-ID: <4AF9AA39.4070206@goop.org>
References: <C71C27D1.1974B%keir.fraser@eu.citrix.com>
	<4AF891B6.8010003@goop.org>
	<E2263E4A5B2284449EEBD0AAB751098418E5238629@PDSMSX501.ccr.corp.intel.com>
	<20091110163626.GC23000@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20091110163626.GC23000@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Jiang,
	Yunhong" <yunhong.jiang@intel.com>, Keir Fraser <keir.fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 11/10/09 08:36, Konrad Rzeszutek Wilk wrote:
> Here is what checkpatch says:
>
> WARNING: do not add new typedefs
> #523: FILE: include/xen/interface/platform.h:328:
> +typedef struct xen_physical_cpuinfo xen_physical_cpuinfo_t;
>
> WARNING: do not add new typedefs
> #537: FILE: include/xen/interface/platform.h:342:
> +typedef struct xenpf_pcpu_info xenpf_pcpu_info_t;
>
> total: 0 errors, 2 warnings, 564 lines checked
>
> /home/konrad/01-dom0_pcpu.patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>   

Unfortunately I think the typedefs are necessary for the GUEST_HANDLE stuff.

    J