From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 02/10] ocfs2: Handle missing dlmconstants.h
Date: Wed, 11 Nov 2009 11:27:32 -0800 [thread overview]
Message-ID: <4AFB1024.3050707@oracle.com> (raw)
In-Reply-To: <20091111025956.GC17774@mail.oracle.com>
Joel Becker wrote:
> Again you're including the kapi-compat header unconditionally.
> Only include it when it is necessary.
>
Ok.
>
>> +#ifdef NO_DLMCONSTANTS_HEADER
>> +#include <linux/types.h>
>> +#include <linux/dlm.h>
>>
>
> Then maybe change this to
>
> #ifndef DLM_LOCK_NL
> # include <linux/dlmconstants.h>
> #endif
>
Not sure why we need to do this.
next prev parent reply other threads:[~2009-11-11 19:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 2:00 [Ocfs2-devel] ocfs2 1.6 - second set of patches Sunil Mushran
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 01/10] ocfs2: Handle workqueue changes Sunil Mushran
2009-11-11 2:57 ` Joel Becker
2009-11-11 18:11 ` Sunil Mushran
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 02/10] ocfs2: Handle missing dlmconstants.h Sunil Mushran
2009-11-11 2:59 ` Joel Becker
2009-11-11 19:27 ` Sunil Mushran [this message]
2009-11-11 22:57 ` Joel Becker
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 03/10] ocfs2: Add helper task_pid_nr() Sunil Mushran
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 04/10] ocfs2: Enable CONFIG_OCFS2_FS_POSIX_ACL Sunil Mushran
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 05/10] ocfs2: Add helper current_umask() Sunil Mushran
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 06/10] ocfs2: Handle missing do_sync_mapping_range() Sunil Mushran
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 07/10] ocfs2: Handle struct f_path in struct file Sunil Mushran
2009-11-11 3:03 ` Joel Becker
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 08/10] ocfs2: Handle struct address_space_operations_ext Sunil Mushran
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 09/10] ocfs2: Handle missing USHORT_MAX Sunil Mushran
2009-11-10 2:00 ` [Ocfs2-devel] [PATCH 10/10] ocfs2: Handle different f_version types Sunil Mushran
2009-11-11 3:13 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFB1024.3050707@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.