All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3: pandora: fix booting without serial attached
Date: Wed, 11 Nov 2009 15:14:13 -0600	[thread overview]
Message-ID: <4AFB2925.6030208@windriver.com> (raw)
In-Reply-To: <1257972979-5963-1-git-send-email-notasas@gmail.com>

Grazvydas Ignotas wrote:
> When the board is booted without serial cable attached (which
> is how most of them will be used) UART RX is left floating and
> sometimes picks noise, which interrupts countdown and enters
> U-Boot prompt instead of booting the kernel. Fix this by setting
> up internal pullup on UART RX pin.
> 
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
>  board/pandora/pandora.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/board/pandora/pandora.h b/board/pandora/pandora.h
> index 5bfa0f9..f1e1db9 100644
> --- a/board/pandora/pandora.h
> +++ b/board/pandora/pandora.h
> @@ -219,7 +219,7 @@ const omap3_sysinfo sysinfo = {
>  	MUX_VAL(CP(UART2_RX),		(IEN  | PTD | EN  | M4)) /*GPIO_147,*/\
>  								 /*UART2_RX*/\
>   /*Serial Interface (Peripheral boot, Linux console, on AV connector)*/\
> -	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTD | DIS | M0)) /*UART3_RX*/\
> +	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTU | EN  | M0)) /*UART3_RX*/\
>  	MUX_VAL(CP(UART3_TX_IRTX),	(IDIS | PTD | DIS | M0)) /*UART3_TX*/\
>   /*LEDs (Controlled by OMAP)*/\
>  	MUX_VAL(CP(MMC1_DAT6),		(IDIS | PTD | DIS | M4)) /*GPIO_128*/\

Will this change disable normal u-boot serial?
 From the config file

/*
  * select serial console configuration
  */
#define CONFIG_CONS_INDEX		3
#define CONFIG_SYS_NS16550_COM3		OMAP34XX_UART3
#define CONFIG_SERIAL3			3

It looks like it will.

This must be as a non default config option.

Tom

  reply	other threads:[~2009-11-11 21:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11 20:56 [U-Boot] [PATCH] OMAP3: pandora: fix booting without serial attached Grazvydas Ignotas
2009-11-11 21:14 ` Tom [this message]
2009-11-11 21:34   ` Grazvydas Ignotas
2009-11-11 23:43     ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFB2925.6030208@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.