[PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5,2

[PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5,2

[Daniel Chen]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

Hi,

Attached please find a patch against current sound-2.6 HEAD adding
the codec SSID for MacBookPro 5,2 to enable playback and capture
(with the same caveat as for MacBookPro 5,1 that jacksense remains
at odds).

Thanks,
Dan

[-- Attachment #2: 0001-ALSA-hda-Use-model-mb5-for-MacBookPro-5-2.patch --]
[-- Type: text/x-patch, Size: 1376 bytes --]

From cf20565172a5e7c4cb940bb5af048aec34411cbe Mon Sep 17 00:00:00 2001
From: Daniel T Chen <crimsun@ubuntu.com>
Date: Wed, 11 Nov 2009 14:32:10 -0500
Subject: [PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5,2

BugLink: https://bugs.launchpad.net/bugs/462098

Until we can look closer at the verbs, let's use ALC885_MB5 for
codec SSID 0x106b4600 to enable playback and capture for MacBookPro
5,2s.

Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
---
 sound/pci/hda/patch_realtek.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 0041ae2..49de107 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8912,10 +8912,11 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x106b, 0x3800, "MacbookPro 4,1", ALC885_MBP3),
 	SND_PCI_QUIRK(0x106b, 0x3e00, "iMac 24 Aluminum", ALC885_IMAC24),
 	SND_PCI_QUIRK(0x106b, 0x3f00, "Macbook 5,1", ALC885_MB5),
-	/* FIXME: HP jack sense seems not working for MBP 5,1, so apparently
-	 * no perfect solution yet
+	/* FIXME: HP jack sense seems not working for MBP 5,1 or 5,2,
+	 * so apparently no perfect solution yet
 	 */
 	SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5),
+	SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5),
 	{} /* terminator */
 };
 
-- 
1.6.3.3


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5, 2

[Takashi Iwai]

At Wed, 11 Nov 2009 14:49:07 -0500,
Daniel Chen wrote:
> 
> Hi,
> 
> Attached please find a patch against current sound-2.6 HEAD adding
> the codec SSID for MacBookPro 5,2 to enable playback and capture
> (with the same caveat as for MacBookPro 5,1 that jacksense remains
> at odds).

Applied now.  Thanks.


Takashi

Re: [PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5, 2

[Justin P. Mattock]

Takashi Iwai wrote:
> At Wed, 11 Nov 2009 14:49:07 -0500,
> Daniel Chen wrote:
>    
>> Hi,
>>
>> Attached please find a patch against current sound-2.6 HEAD adding
>> the codec SSID for MacBookPro 5,2 to enable playback and capture
>> (with the same caveat as for MacBookPro 5,1 that jacksense remains
>> at odds).
>>      
>
> Applied now.  Thanks.
>
>
> Takashi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
>    
Any ideas with the status of the imac9,1?

Justin P. Mattock

Re: [PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5, 2

[Takashi Iwai]

At Wed, 11 Nov 2009 22:45:11 -0800,
Justin P. Mattock wrote:
> 
> Takashi Iwai wrote:
> > At Wed, 11 Nov 2009 14:49:07 -0500,
> > Daniel Chen wrote:
> >    
> >> Hi,
> >>
> >> Attached please find a patch against current sound-2.6 HEAD adding
> >> the codec SSID for MacBookPro 5,2 to enable playback and capture
> >> (with the same caveat as for MacBookPro 5,1 that jacksense remains
> >> at odds).
> >>      
> >
> > Applied now.  Thanks.
> >
> >
> > Takashi
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
> >    
> Any ideas with the status of the imac9,1?

Sorry, I have no idea.  If you have such, please try the latest one
and update the status report.


Takashi

Re: [PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5, 2

[Justin P. Mattock]

Takashi Iwai wrote:
>
> Sorry, I have no idea.  If you have such, please try the latest one
> and update the status report.
>
>
> Takashi
>
>    
There was a patch that was submitted probably around
8 to 10 months ago, that actually works(really good)
but never made it into upstream.(keep in mind it's broken
now with all of the changes to patch_realtek.c).

Anyways AFAIK the only option to kindof work(partially
is mb3 horrifically). Anyways if there's nothing then
there's nothing...(hopefully the new imac's work).

Justin P. Mattock

Re: [PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5, 2

[Takashi Iwai]

At Wed, 11 Nov 2009 23:30:37 -0800,
Justin P. Mattock wrote:
> 
> Takashi Iwai wrote:
> >
> > Sorry, I have no idea.  If you have such, please try the latest one
> > and update the status report.
> >
> >
> > Takashi
> >
> >    
> There was a patch that was submitted probably around
> 8 to 10 months ago, that actually works(really good)

Well, I vaguely remember that I requested repost or a proper sign-off.
Did I miss it?

> but never made it into upstream.(keep in mind it's broken
> now with all of the changes to patch_realtek.c).

Would be helpful if you rebase / fix and repost.


thanks,

Takashi

Re: [PATCH] ALSA: hda: Use model=mb5 for MacBookPro 5, 2

[Justin P. Mattock]

Takashi Iwai wrote:
> At Wed, 11 Nov 2009 23:30:37 -0800,
> Justin P. Mattock wrote:
>    
>> Takashi Iwai wrote:
>>      
>>> Sorry, I have no idea.  If you have such, please try the latest one
>>> and update the status report.
>>>
>>>
>>> Takashi
>>>
>>>
>>>        
>> There was a patch that was submitted probably around
>> 8 to 10 months ago, that actually works(really good)
>>      
>
> Well, I vaguely remember that I requested repost or a proper sign-off.
> Did I miss it?
>
>    
your right.. the guy like vanished into thin air.
>> but never made it into upstream.(keep in mind it's broken
>> now with all of the changes to patch_realtek.c).
>>      
>
> Would be helpful if you rebase / fix and repost.
>
>
> thanks,
>
> Takashi
>
>    
I've been meaning to see if I can get something
from the old to the new(might take a while).

a bit concerned about the author though. the guy shouldn't
(if this is his work) post a module then take off like that.

Justin P. mattock