All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] redundant code in common/cmd_i2c.
Date: Thu, 12 Nov 2009 09:14:21 +0100	[thread overview]
Message-ID: <4AFBC3DD.5080800@denx.de> (raw)
In-Reply-To: <880fa7950911110714w54afa0a4h896dcb64dc82e4c0@mail.gmail.com>

Hello PratapChandu,

PratapChandu wrote:
> The following code fragment in the file common/cmd_i2c.c  seems to be redundant.
> Is not good to delete  ?
> 
> Line 330 - 336 is like below
> 
> #if 0
>         for (timeout = 0; timeout < 10; timeout++) {
>             udelay(2000);
>             if (i2c_probe(chip) == 0)
>                 break;
>         }
> #endif

Yes, this seems to be dead code. Please provide a patch for removing
it.

Thanks.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-11-12  8:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11 15:14 [U-Boot] redundant code in common/cmd_i2c PratapChandu
2009-11-12  8:14 ` Heiko Schocher [this message]
2009-11-12 14:38   ` Detlev Zundel
2009-11-13 10:03     ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFBC3DD.5080800@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.