From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] DA830: Add pinmux for USB0_DRVVBUS
Date: Thu, 12 Nov 2009 10:10:16 -0600 [thread overview]
Message-ID: <4AFC3368.40307@windriver.com> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D93F2EF1B@dlee01.ent.ti.com>
Paulraj, Sandeep wrote:
>
>> Ajay Kumar Gupta wrote:
>>> USB0_DRVVBUS pinmux configuration is required for USB functinality
>>> in uboot.
>>>
>>> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>>> Signed-off-by: Swaminathan S <swami.iyer@ti.com>
>>> ---
>>> This patch set is created against Nick Thompson's latest patch set
>>> (v5) on DA8xx support and another patch from him on Davinci pinmux.
>>> [Davinci: add a pin multiplexer configuration API]
>> It is difficult to review code that is dependent on other outstanding
>> patches.
>>
>> The base DA8xx support will be in arm-ti branch shortly.
>> Please rebase these patches when this happens and resubmit.
>>
>> Tom
>
> I think he might have added it locally and then made his patches.
> So he might not have to rebase.
>
> Without Nick's patches da830evm.c would not even exist :-)
>
>
My issue is not with how development continues, it is with how patches
are reviewed. To really review this patchset someone would need to
apply the pin mux patch, the the 8xx patch set, then this set.
Reviewing patches against outstanding patches does not scale and should be
avoided.
Tom
next prev parent reply other threads:[~2009-11-12 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 15:39 [U-Boot] [PATCH 1/3] DA830: Add pinmux for USB0_DRVVBUS Ajay Kumar Gupta
2009-11-12 15:39 ` [U-Boot] [PATCH 2/3] DA8xx: Add MUSB host support Ajay Kumar Gupta
2009-11-12 15:39 ` [U-Boot] [PATCH 3/3] DA830: Add usb config Ajay Kumar Gupta
2009-11-12 16:55 ` Nick Thompson
2009-11-13 3:25 ` Gupta, Ajay Kumar
2009-11-12 16:26 ` [U-Boot] [PATCH 2/3] DA8xx: Add MUSB host support Nick Thompson
2009-11-12 16:41 ` Paulraj, Sandeep
2009-11-12 15:47 ` [U-Boot] [PATCH 1/3] DA830: Add pinmux for USB0_DRVVBUS Tom
2009-11-12 15:58 ` Paulraj, Sandeep
2009-11-12 16:10 ` Tom [this message]
2009-11-12 16:29 ` Paulraj, Sandeep
2009-11-13 4:19 ` Gupta, Ajay Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFC3368.40307@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.