diff for duplicates of <4AFC3620.2020809@schaufler-ca.com> diff --git a/a/1.txt b/N1/1.txt index 0273bf8..64a53ed 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,8 +20,8 @@ Julia Lawall wrote: >>>> sbsec->flags &= ~SE_SBLABELSUPP; >>>> >>>> /* Special handling for sysfs. Is genfs but also has setxattr handler*/ ->>>> - if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs")) = 0) ->>>> + if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs") - 1) = 0) +>>>> - if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs")) == 0) +>>>> + if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs") - 1) == 0) >>>> sbsec->flags |= SE_SBLABELSUPP; >>>> >>> Shouldn't this be a simple strcmp() ? diff --git a/a/content_digest b/N1/content_digest index 63817f7..87e5709 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\0Pine.LNX.4.64.0911121556390.19779@ask.diku.dk\0" "From\0Casey Schaufler <casey@schaufler-ca.com>\0" "Subject\0Re: [PATCH 3/4] security/selinux: decrement sizeof size in strncmp\0" - "Date\0Thu, 12 Nov 2009 16:21:52 +0000\0" + "Date\0Thu, 12 Nov 2009 08:21:52 -0800\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0Serge E. Hallyn <serue@us.ibm.com>" James Morris <jmorris@namei.org> @@ -37,8 +37,8 @@ ">>>> \t\tsbsec->flags &= ~SE_SBLABELSUPP;\n" ">>>> \n" ">>>> \t/* Special handling for sysfs. Is genfs but also has setxattr handler*/\n" - ">>>> -\tif (strncmp(sb->s_type->name, \"sysfs\", sizeof(\"sysfs\")) = 0)\n" - ">>>> +\tif (strncmp(sb->s_type->name, \"sysfs\", sizeof(\"sysfs\") - 1) = 0)\n" + ">>>> -\tif (strncmp(sb->s_type->name, \"sysfs\", sizeof(\"sysfs\")) == 0)\n" + ">>>> +\tif (strncmp(sb->s_type->name, \"sysfs\", sizeof(\"sysfs\") - 1) == 0)\n" ">>>> \t\tsbsec->flags |= SE_SBLABELSUPP;\n" ">>>> \n" ">>> Shouldn't this be a simple strcmp() ?\n" @@ -77,4 +77,4 @@ ">\n" > -3dfc8565e52942bb87536a8d782ff02fcabd8ae79d2133b6749a324c3bc6d2a8 +122f6984c025d1b718196b384c26137782195d6ac0daa5c5be8c199b6de8435b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.