Re: [PATCH] act_mirred: cleanup and optimization

[Patrick McHardy <kaber@trash.net>]

Changli Gao wrote:
> On Fri, Nov 13, 2009 at 3:13 PM, Patrick McHardy <kaber@trash.net> wrote:
>> Changli Gao wrote:
>>> act_mirred: cleanup and optimization.
>>>
>>> cleanup and optimization.
>>> 1. don't let go back using goto.
>>> 2. move checking if eaction is valid in tcf_mirred_init().
>>> 3. don't call skb_act_clone() until it is necessary.
>>> 4. one exit of the critical context.
>>> 5. allow eaction is TCA_INGRESS_MIRROR & TCA_INGRESS_REDIR.
>>>
>>>       if (parm->ifindex) {
>>> -             dev = __dev_get_by_index(&init_net, parm->ifindex);
>>> +             dev = dev_get_by_index(&init_net, parm->ifindex);
>>>               if (dev == NULL)
>>>                       return -ENODEV;
>> This change is not mentioned in the changelog and introduces a
>> leak. Please split your patches into reasonable portions doing
>> one change at a time.
>>
> 
> Leak? Do I forget to put it some where? I'll keep it as a whole until
> Jamal thinks it is in the right form and direction.

Ah sorry, I misread the patch.