From: Patrick McHardy <kaber@trash.net>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Yin, Kangkai" <kangkai.yin@intel.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_log: fix sleeping function called from invalid context in seq_show()
Date: Fri, 13 Nov 2009 09:35:36 +0100 [thread overview]
Message-ID: <4AFD1A58.6090201@trash.net> (raw)
In-Reply-To: <20091113063640.GA29012@localhost>
Wu Fengguang wrote:
> [ 171.925285] BUG: sleeping function called from invalid context at kernel/mutex.c:280
> [ 171.925296] in_atomic(): 1, irqs_disabled(): 0, pid: 671, name: grep
> [ 171.925306] 2 locks held by grep/671:
> [ 171.925312] #0: (&p->lock){+.+.+.}, at: [<c10b8acd>] seq_read+0x25/0x36c
> [ 171.925340] #1: (rcu_read_lock){.+.+..}, at: [<c1391dac>] seq_start+0x0/0x44
> [ 171.925372] Pid: 671, comm: grep Not tainted 2.6.31.6-4-netbook #3
> [ 171.925380] Call Trace:
> [ 171.925398] [<c105104e>] ? __debug_show_held_locks+0x1e/0x20
> [ 171.925414] [<c10264ac>] __might_sleep+0xfb/0x102
> [ 171.925430] [<c1461521>] mutex_lock_nested+0x1c/0x2ad
> [ 171.925444] [<c1391c9e>] seq_show+0x74/0x127
> [ 171.925456] [<c10b8c5c>] seq_read+0x1b4/0x36c
> [ 171.925469] [<c10b8aa8>] ? seq_read+0x0/0x36c
> [ 171.925483] [<c10d5c8e>] proc_reg_read+0x60/0x74
> [ 171.925496] [<c10d5c2e>] ? proc_reg_read+0x0/0x74
> [ 171.925510] [<c10a4468>] vfs_read+0x87/0x110
> [ 171.925523] [<c10a458a>] sys_read+0x3b/0x60
> [ 171.925538] [<c1002a49>] syscall_call+0x7/0xb
>
> Fix it by replacing RCU with nf_log_mutex.
Applied, thanks.
prev parent reply other threads:[~2009-11-13 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 6:36 [PATCH] netfilter: nf_log: fix sleeping function called from invalid context in seq_show() Wu Fengguang
2009-11-13 8:35 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFD1A58.6090201@trash.net \
--to=kaber@trash.net \
--cc=fengguang.wu@intel.com \
--cc=kangkai.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.