All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "Gadiyar, Anand" <gadiyar@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] omap3: Change the default silicon
Date: Fri, 13 Nov 2009 04:15:47 -0600	[thread overview]
Message-ID: <4AFD31D3.6060805@ti.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB59301DE4C486C@dbde02.ent.ti.com>

Premi, Sanjeev had written, on 11/13/2009 04:10 AM, the following:
>> -----Original Message-----
>> From: Gadiyar, Anand 
>> Sent: Friday, November 13, 2009 10:41 AM
>> To: Tony Lindgren; Premi, Sanjeev
>> Cc: linux-omap@vger.kernel.org
>> Subject: RE: [PATCH] omap3: Change the default silicon
>>
>> Tony Lindgren wrote:
>>> * Sanjeev Premi <premi@ti.com> [091029 07:35]:
>>>> Currently the default silicon - in absence of
>>>> identification - is set to OMAP3630 ES1.0.
>>>>
>>>> Though, condition may/should not arise; but
>>>> the default should be latest in the most
>>>> common silicon variant - currently OMAP3430
>>>> ES3.1.
>>> Is this still needed? To me it seems more likely there will
>>> more 3630 based silicon than 3430 based silicon?
>>>
>> 3430 ES3.1s are the most common I believe. All boards in the wild
>> are 3430 based.
>>
>> 3630 is just coming up and will take a while to be as common.
>>
>> IMO, 3430 ES3.1 should be default.
>>
>> - Anand
> 
> [sp] That's exactly the reason for this patch.
>      There is a small typo in the comment though :(
> 
> 		/* Unknown. Default to latest among all variants */
> Should be:
> 		/* Unknown. Default to common among all variants */
> 
>      Sending a v2 for the same.
> 

I believe this patch should be dropped -> here is why -> if you have new 
silicons that are in 3430 category, you should be sending patches for 
them ;)..

The latest and greatest in the bucket of silicons is 3630 and I would 
rather go with felipe's patch [1] cleaning up the id.c than this -> in 
my opinion, hitting this condition is only because you have the next 
generation of devices..


-- 
Regards,
Nishanth Menon

Ref:
[1]: http://patchwork.kernel.org/patch/59540/

  reply	other threads:[~2009-11-13 10:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29 14:35 [PATCH] omap3: Change the default silicon Sanjeev Premi
2009-11-12 22:21 ` Tony Lindgren
2009-11-13  5:11   ` Gadiyar, Anand
2009-11-13 10:10     ` Premi, Sanjeev
2009-11-13 10:15       ` Nishanth Menon [this message]
2009-11-13 10:53         ` Premi, Sanjeev
2009-11-13 11:01           ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFD31D3.6060805@ti.com \
    --to=nm@ti.com \
    --cc=gadiyar@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=premi@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.