All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] DA8xx: Add MUSB host support
Date: Fri, 13 Nov 2009 11:05:49 -0600	[thread overview]
Message-ID: <4AFD91ED.5010909@windriver.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E73940436981181@dbde02.ent.ti.com>

Gupta, Ajay Kumar wrote:
> Hi,
>> Tested USB host functionality on DA830 EVM.
>>
>> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>> Signed-off-by: Swaminathan S <swami.iyer@ti.com>
>> ---
> 
> <snip..>
> 
>> --- a/include/usb.h
>> +++ b/include/usb.h
>> @@ -183,7 +183,8 @@ struct usb_device {
>>  #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \
>>       defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \
>>       defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \
>> -     defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI)
>> +     defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \
>> +     defined(CONFIG_USB_DA8XX)
> 
>> These are aligned incorrectly (should be 4 spaces rather than a tab)
> It was originally with tabs only. Are you suggesting to change all 5 lines to match the alignment ?
> 
> Tom,
> What do you think on this one?

In general tabs are preferred but I would like to review the entire patchset.
When you make changes to a subset of the patches, you must repost the entire 
patchset.

Please repost the entire patchset.

Tom


> 
> -Ajay

  reply	other threads:[~2009-11-13 17:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 13:05 [U-Boot] [PATCH v3] DA8xx: Add MUSB host support Ajay Kumar Gupta
2009-11-13 14:22 ` Nick Thompson
2009-11-13 16:47   ` Gupta, Ajay Kumar
2009-11-13 17:05     ` Tom [this message]
2009-11-13 17:09       ` Gupta, Ajay Kumar
2009-11-13 17:28         ` Tom
2009-11-16  9:18     ` Nick Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFD91ED.5010909@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.