Re: [PATCH 8/9 v2] omap3: pm: introduce dynamic OPP

["Menon, Nishanth" <nm@ti.com>]

Kevin Hilman said the following on 11/13/2009 07:31 PM:
[...]
>> +void __init omap3_pm_init_opp_table(void)
>> +{
>> +	/* Populate the base CPU rate tables here */
>> +	omap3_mpu_rate_table = kmalloc(sizeof(omap34xx_mpu_rate_table),
>> +			GFP_KERNEL);
>> +	omap3_dsp_rate_table = kmalloc(sizeof(omap34xx_dsp_rate_table),
>> +			GFP_KERNEL);
>> +	omap3_l3_rate_table = kmalloc(sizeof(omap34xx_l3_rate_table),
>> +			GFP_KERNEL);
>> +
>> +	BUG_ON(!omap3_mpu_rate_table || !omap3_dsp_rate_table ||
>> +		!omap3_l3_rate_table);
>> +
>> +	memcpy(omap3_mpu_rate_table, omap34xx_mpu_rate_table,
>> +			sizeof(omap34xx_mpu_rate_table));
>> +	memcpy(omap3_dsp_rate_table, omap34xx_dsp_rate_table,
>> +			sizeof(omap34xx_dsp_rate_table));
>> +	memcpy(omap3_l3_rate_table, omap34xx_l3_rate_table,
>> +			sizeof(omap34xx_l3_rate_table));
>> +}
>> +
>>     
>
> Minor issue, but FYI... rather than the kmalloc + memcpy, you can use
> kmemdup() to do the same thing
thanks.
Regards,
Nishanth Menon