From: Lars-Peter Clausen <lars@metafoo.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: pcf50633 - fix error handling during probe
Date: Mon, 16 Nov 2009 00:09:22 +0100 [thread overview]
Message-ID: <4B008A22.80909@metafoo.de> (raw)
In-Reply-To: <20091109092516.29634.32640.stgit@localhost.localdomain>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dmitry Torokhov wrote:
> The pcf50633 is very naive - it assumes that all driver core
> operations will succeed and will fail badly if one of them
> errors out. Implement proper error handling and make sure we
> release any and all resources that have been allocated prior
> to failure.
>
> Also avoid memory leak when using platform_device_add_data()
> which clones the supplied data structure for use by the device.
> The original copy, if allocated dynamically, needs to be freed
> by the caller; switch to using on-stack variable (the size of
> the structure in question is quite small) instead.
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Hi
Most of the issues addressed in this patch have already been fixed.
Please check the for-next branch in the mfd tree.
- - Lars
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAksAiiIACgkQBX4mSR26RiNJbACfYs4UhLSrlYuNqynJ/Mguw+oj
FxQAn2xmUh8QZttY4jxKUsdg+6p/pXNT
=yCtL
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2009-11-15 23:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 9:25 [PATCH 0/2] pcf50633 - a couple of fixes Dmitry Torokhov
2009-11-09 9:25 ` [PATCH 1/2] mfd: pcf50633 - fix error handling during probe Dmitry Torokhov
2009-11-15 22:18 ` Samuel Ortiz
2009-11-15 23:09 ` Lars-Peter Clausen [this message]
2009-11-15 23:25 ` Samuel Ortiz
2009-11-09 9:25 ` [PATCH 2/2] mfd: pcf50633 - use threaded interrupts Dmitry Torokhov
2009-11-15 22:22 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B008A22.80909@metafoo.de \
--to=lars@metafoo.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.