All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
To: Keir Fraser <Keir.Fraser@eu.citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 0/7][RFC] make xenguest save & restore functions reentrant
Date: Mon, 16 Nov 2009 11:39:41 +0000	[thread overview]
Message-ID: <4B0139FD.2060703@eu.citrix.com> (raw)
In-Reply-To: <C7258650.1A277%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> Another option would be for all users of the macros to have a 'xenguest_ctx'
> structure, or whatever you call it. So e.g., in xc_resume:
>  struct xenguest_ctx _ctx, *ctx = &_ctx;
>  ctx->guest_width = ...
>  /* Leave unnecessary/meaningless fields for this caller uninitialised. */
> 
> What do you think? The ctx struct can't be that big; we can just ignore
> fields that make no sense outside save/restore (i.e., kind of split it into
> general-purpose and private/application-specific fields); and it does keep
> the macro invocations cleaner.

I'll give that a try. I don't think it's going to make that serie much 
nicer though.

-- 
Vincent

      reply	other threads:[~2009-11-16 11:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 23:43 [PATCH 0/7][RFC] make xenguest save & restore functions reentrant Vincent Hanquez
2009-11-13 23:43 ` [PATCH 1/7] add explicit parameter to macros instead of assuming symbol name available on the stack or as a global variable Vincent Hanquez
2009-11-13 23:43 ` [PATCH 2/7] p2m_size is unnecessarily passed as a parameter when it's available " Vincent Hanquez
2009-11-13 23:43 ` [PATCH 3/7] move global variables in suspend into a global context Vincent Hanquez
2009-11-13 23:43 ` [PATCH 4/7] move the suspend_ctx on the save stack instead of a global one Vincent Hanquez
2009-11-13 23:43 ` [PATCH 5/7] alias i/FPP(guest_width) as p2m_index and replace every usage Vincent Hanquez
2009-11-13 23:43 ` [PATCH 6/7] move restore global variables into a global context Vincent Hanquez
2009-11-13 23:43 ` [PATCH 7/7] pass restore context as an argument instead of " Vincent Hanquez
2009-11-14  8:25 ` [PATCH 0/7][RFC] make xenguest save & restore functions reentrant Keir Fraser
2009-11-15 10:08   ` Vincent Hanquez
2009-11-15 10:20     ` Keir Fraser
2009-11-16 11:39       ` Vincent Hanquez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0139FD.2060703@eu.citrix.com \
    --to=vincent.hanquez@eu.citrix.com \
    --cc=Keir.Fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.