Re: [Qemu-devel] [PATCH] Don't leak file descriptors

[Kevin Wolf <kwolf@redhat.com>]

Am 13.11.2009 22:05, schrieb Blue Swirl:
> On Fri, Nov 13, 2009 at 5:17 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>> We're leaking file descriptors to child processes. Set FD_CLOEXEC on file
>> descriptors that don't need to be passed to children to stop this misbehaviour.
> 
>> -        c = accept(s, (struct sockaddr *)&addr, &addrlen);
>> +        c = qemu_accept(s, (struct sockaddr *)&addr, &addrlen);
> 
> Would it be possible to improve the interface so that no casts are
> needed for the calling code?

How exactly would you do that? The only way I see to do it would be
using void*, but I'm not sure if this really is an improvement.

Kevin