From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NA3IG-0008Oy-AN
	for qemu-devel@nongnu.org; Mon, 16 Nov 2009 10:15:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NA3IA-0008HT-Pg
	for qemu-devel@nongnu.org; Mon, 16 Nov 2009 10:15:03 -0500
Received: from [199.232.76.173] (port=37312 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NA3IA-0008HP-Lp
	for qemu-devel@nongnu.org; Mon, 16 Nov 2009 10:14:58 -0500
Received: from cantor.suse.de ([195.135.220.2]:39943 helo=mx1.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1NA3IA-0004gr-9g
	for qemu-devel@nongnu.org; Mon, 16 Nov 2009 10:14:58 -0500
Message-ID: <4B016C6F.1020209@suse.de>
Date: Mon, 16 Nov 2009 16:14:55 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 01/12] TCG "sync" op
References: <1256133153-3121-1-git-send-email-uli@suse.de>
	<200911110056.48147.paul@codesourcery.com>
	<4B015986.6040704@suse.de>
	<200911161437.32519.paul@codesourcery.com>
In-Reply-To: <200911161437.32519.paul@codesourcery.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

Paul Brook wrote:
>>> While sync appears attractive as a quick hack to achieve this, I think it
>>> is liable to be abused, and cause us serious pain long-term. If you need
>>> an easy solution then use ld/st (as with ARM VFP registers). If you want
>>> a good solution then fix whichever bit of TCG makes accessing a pair of
>>> registers horribly slow. We already have some support for this
>>> (concat_i32_i64).
>>>       
>> Could we please include it nevertheless? I don't want to see S390 TCG
>> and KVM targets not included because of this sync operation.
>>
>> If you like, add some big fat warning around it and maybe break
>> compilation if anyone but the s390 target uses that sync op, but let's
>> not keep a whole target from inclusion because of a single feature that
>> _might_ one day affect others.
>>     
>
> I'd rather not include sync, and instead use the explicit ld/st code you 
> already wrote.
>   

As long as the KVM code comes in I'm good. I don't really care that much
about the TCG parts and only need them to have the build system
surroundings set up.

So yes, I don't care about sync. As long as we finally get any solution
here I'm good, but patches lying around for weeks surely doesn't help qemu.


Alex