Re: [PATCH] libata: Add ALPM power state accounting to the AHCI driver

[Tejun Heo <tj@kernel.org>]

Hello, Arjan.

Arjan van de Ven wrote:
> I think I'm waaaay out of my league in terms of understanding the
> libata structure in the things you are suggesting to be honest, and I
> do not feel I understand enough of the subtleties in this area.

SCR access is a bit subtle because it requires issuing commands if the
link is behind PMP and internal commands currently assume EH context.
This is true for all link functions, so I'm suggesting the stats
helpers to follow the same convention.  This will also make slave link
configuration work properly (controllers which present two SATA links
as master/slave of the same port but still provide access to separate
SCR registers).  You know, it's a link function, make it take a link
as all other stuff is designed that way.

Thanks.

-- 
tejun