All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: Add support for connected INET sockets
Date: Mon, 16 Nov 2009 13:38:08 -0500	[thread overview]
Message-ID: <4B019C10.8050609@cs.columbia.edu> (raw)
In-Reply-To: <1257878856-25520-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>


The patches look good, see a few comments per patch.

Before I pull, please (1) use ckpt_err() instead of ckpt_write_err(),
and also use ckpt_err() in the restart path where it makes sense.

I should be pushing v19-rc1 by tomorrow, perhaps better wait.

Thanks,

Oren.

Dan Smith wrote:
> This set includes the previous INET connected sockets patch with a few
> trivial changes suggested by Oren, as well as the readme update.  The
> first patch fixes socket buffer checkpoint to include fragments, and
> includes the changes in the previous first patch that added header mark
> information.  As a result, this set now also includes a fix to the UNIX
> code to cope with the change.
> 
> _______________________________________________
> Containers mailing list
> Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
> 

  parent reply	other threads:[~2009-11-16 18:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 18:47 Add support for connected INET sockets Dan Smith
     [not found] ` <1257878856-25520-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-10 18:47   ` [PATCH 1/4] Unify skb read/write functions and fix for fragmented buffers Dan Smith
     [not found]     ` <1257878856-25520-2-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-11 20:02       ` Serge E. Hallyn
2009-11-16 18:30       ` Oren Laadan
     [not found]         ` <4B019A2C.9090507-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-11-16 18:51           ` Dan Smith
     [not found]             ` <87einyuwum.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-11-16 19:05               ` Oren Laadan
2009-11-10 18:47   ` [PATCH 3/4] Update the UNIX buffer restore code to match the new format saved in the image file Dan Smith
     [not found]     ` <1257878856-25520-4-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-11 21:38       ` Serge E. Hallyn
     [not found]         ` <20091111213851.GE8761-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-11 21:57           ` Dan Smith
     [not found]             ` <87vdhgvi6b.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-11-12  2:18               ` Serge E. Hallyn
     [not found]                 ` <20091112021824.GA14646-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-12 18:19                   ` Dan Smith
     [not found]                     ` <87k4xvvc5b.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-11-12 19:43                       ` Serge E. Hallyn
2009-11-16 18:35                   ` Oren Laadan
2009-11-11 21:40       ` Serge E. Hallyn
2009-11-10 18:47   ` [PATCH 4/4] Add some content to the readme.txt for socket c/r Dan Smith
2009-11-16 18:38   ` Oren Laadan [this message]
2009-11-10 18:47 ` [PATCH 2/4] [RFC] Add c/r support for connected INET sockets (v4) Dan Smith
2009-11-11 20:32   ` Serge E. Hallyn
  -- strict thread matches above, loose matches on Subject: below --
2009-11-17 15:26 Add support for connected INET sockets Dan Smith
     [not found] ` <1258471590-29768-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-25 18:51   ` Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B019C10.8050609@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.