All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zach Brown <zach.brown@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Shaohua Li <shaohua.li@intel.com>,
	linux-kernel@vger.kernel.org, bcrl@kvack.org,
	Jeff Moyer <jmoyer@redhat.com>,
	David Brownell <dbrownell@users.sourceforge.net>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH]aio: remove unused field
Date: Mon, 16 Nov 2009 13:12:28 -0800	[thread overview]
Message-ID: <4B01C03C.6000309@oracle.com> (raw)
In-Reply-To: <20091113143408.c7965e74.akpm@linux-foundation.org>


> If we do this then kick_iocb() has only one in-kernel caller, in
> drivers/usb/gadget/inode.c.  I wonder if the gadget code really needs
> to be using kick_iocb()?

I don't think that it needs to, no.  It's only using the aio retry
functionality to perform a copy of read data into user space.

I have a patch to switch it to using schedule_work() instead:

  http://marc.info/?l=linux-fsdevel&m=125624446623075&w=2

I've been focusing on other things instead of pushing that to the usb
folks to be tested and merged, though.  I've cc:ed them in case they
want to run with this.

- z

      reply	other threads:[~2009-11-16 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12  7:52 [PATCH]aio: remove unused field Shaohua Li
2009-11-12 13:39 ` Jeff Moyer
2009-11-13 22:34 ` Andrew Morton
2009-11-16 21:12   ` Zach Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B01C03C.6000309@oracle.com \
    --to=zach.brown@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=bcrl@kvack.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.